Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[util] Limit fps in The Incredibles #3549

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

Blisto91
Copy link
Contributor

@Blisto91 Blisto91 commented Jul 5, 2023

The higher uneven framerates can bug the game out. The horrible frame timings is allegedly because even though it appears uncapped besides vsync it will try to reach for 60fps. Even then it has some frame time issues, so opted to cap it just below.

Screenshots

uncapped
1

60
2

59
3

@K0bin
Copy link
Collaborator

K0bin commented Jul 5, 2023

I'm not entirely against this but do we really want to keep workarounds for every last shovelware game?

@Blisto91
Copy link
Contributor Author

Blisto91 commented Jul 5, 2023

Dunno. Up to you guys how much and what you wanna accept ofc.

On a semi related note i don't know if it's been considered to move the built in configs in to another more organized file format or split them up? Just if it starts getting too cluttered or packed in a regular code file.

@jams3223
Copy link

jams3223 commented Jul 5, 2023

I'm not entirely against this but do we really want to keep workarounds for every last shovelware game?

I agree, developers need to fix their games, we shouldn't be the one doing their job.

@K0bin
Copy link
Collaborator

K0bin commented Jul 5, 2023

@jams3223 That's not gonna happen, especially not for 20 year old games. I'm definitely in favor of working around bugs so our users have a good out of the box experience in popular games. I just don't think we should do it for every game.

@misyltoad misyltoad merged commit 6be1f6d into doitsujin:master Jul 5, 2023
2 of 3 checks passed
@jams3223
Copy link

jams3223 commented Jul 6, 2023

@jams3223 That's not gonna happen, especially not for 20 year old games. I'm definitely in favor of working around bugs so our users have a good out of the box experience in popular games. I just don't think we should do it for every game.

These developers could remaster their game and fix the issues, it would be a win win as they could increase the pricing but anyways developers nowadays are only looking for a cash grab that's why i mostly but innovative or indie games, there's nothing out of the box that triple A studio tries to do anymore other than Indies, Nintendo and Valve when they finally choose to release a game.

@Blisto91 Blisto91 deleted the incredibles branch July 6, 2023 07:00
@jams3223
Copy link

jams3223 commented Jul 6, 2023

@Joshua-Ashton can we drop the workaround for Resident Evil 2 & 3 as they've removed support for DX11, the game only use DX12 for now on.

@Blisto91
Copy link
Contributor Author

Blisto91 commented Jul 6, 2023

The old d3d11 version is still available as a beta option in Steam and used by a bunch of people I believe. Just as a extra note.

@jams3223
Copy link

jams3223 commented Jul 6, 2023

The old d3d11 version is still available as a beta option in Steam and used by a bunch of people I believe. Just as a extra note.

Yeah you're right maybe we should wait a couple of months before we do that since some people are starting to complain that their losing compatibility with the game or have issues that the dev won't ever fix since the dx11 version is abandonware.

@K0bin
Copy link
Collaborator

K0bin commented Jul 6, 2023

These developers could remaster their game and fix the issues, it would be a win win as they could increase the pricing but anyways developers nowadays are only looking for a cash grab that's why i mostly but innovative or indie games, there's nothing out of the box that triple A studio tries to do anymore other than Indies, Nintendo and Valve when they finally choose to release a game.

That's often not possible because of licensing and it would require people to buy the game again.

Yeah you're right maybe we should wait a couple of months before we do that

We're not gonna drop the RE2 or RE3 config. There's simply no reason to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants