Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPF Record verification fails for domains starting with "all" #145

Open
ricco386 opened this issue Aug 14, 2024 · 1 comment
Open

SPF Record verification fails for domains starting with "all" #145

ricco386 opened this issue Aug 14, 2024 · 1 comment

Comments

@ricco386
Copy link

If a SPF record has string all in domain, the regular expresion fails with error:

The domain spf.all does not exist

For example domain: allianz.sk has a SPF record: "v=spf1 ip4:91.206.87.24 ip4:91.206.86.232 ip4:91.206.87.210 ip4:208.73.7.175 mx include:mcxplatform.de include:spf.allianz.com -all" which seems to be correct, but executing: spf = check_spf('allianz.sk') results with an error.
@ricco386
Copy link
Author

Problem seems to be a regex in spf.py on line 42:

AFTER_ALL_REGEX_STRING = r"\ball\s*[^\s]+"

ricco386 added a commit to ricco386/checkdmarc that referenced this issue Aug 14, 2024
@ricco386
Fix bug domainaware#145
2690627 
Regex was too wide and was catching if the domain starts with `all`.
maxime-huyghe pushed a commit to maxime-huyghe/checkdmarc that referenced this issue Sep 26, 2024
Fix SPF Record verification failing for domains with a label starting…
70a178e 
… with "all" (domainaware#145)
@Tazmaniac Tazmaniac mentioned this issue Sep 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ricco386