Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache doesn't work in _query_dns #79

Closed
jlaundry opened this issue Sep 13, 2022 · 0 comments
Closed

Cache doesn't work in _query_dns #79

jlaundry opened this issue Sep 13, 2022 · 0 comments
Labels

Comments

@jlaundry
Copy link
Contributor

Currently, _query_dns uses the following logic to see if a cache should be used:

checkdmarc/checkdmarc.py

Lines 637 to 640 in 7cc07db

if cache is None:
cache = DNS_CACHE
if cache:
records = cache.get(cache_key, None)

However, if cache doesn't return True if cache is an ExpiringDict, so the cache is never used.

seanthegeek pushed a commit that referenced this issue Oct 4, 2022
seanthegeek pushed a commit that referenced this issue Oct 4, 2022
- Fix: Cache doesn't work in _query_dns #79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants