Issue #136 - Bugfix test_dnssec method cache #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran into the same issue and it fixed it for me. @mohammad-latacora Thank you! |
seanthegeek
added a commit
that referenced
this pull request
Jul 16, 2024
- Fix TLS/STARTTLS check (Fixes issue #138) - Consider `tls: true` if `starttls: true` - Handle records not existing if ignoring unrelated records (PR #131 fixes #130) - Query the base domain if a DMARC record is not found at the subdomain (PR #132) - Do not accept `include=` in the SPF record (PR #134 fixes issue #134) - Fix DNSSEC cache (PR #136 Fixes issue #137) - Fixed checking whether there is some text after `all` SPF directive (PR #139)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checkdmarc/checkdmarc/dnssec.py
Line 109 in 3d3da6e
This line is attempting to access a cache within a cache. This throws an
unhashable type: 'ExpiringDict'error.This PR proposes replacing that with the following
Which is identical to what is used by the
get_dnskeymethod on line 57