Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve the NetworkImage issue on IOS #168

Merged
merged 2 commits into from
Nov 10, 2021

Conversation

DevYuns
Copy link
Contributor

@DevYuns DevYuns commented Nov 10, 2021

Description

NetworkImage had some issue about image on ios.

Problem

renderImage should render url source After needLoading turns into false in useEffect. But renderImage shows a previous image(This case loadingSource) in a very short time before they finished to load url image. It was very short short moment, but It was clearly stood out. It may related this issue. So I give a key props to renderImage, then solve the problem. Furthermore, I implemented memoization with useCallback and useMemo.

Test Plan

N/A

Related Issues

Refer this issue

Tests

I added the following tests:

snapshot update

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Run yarn test:all and make sure nothing fails. You can run yarn test -u to update snapshots if needed.
  • I am willing to follow-up on review comments in a timely manner.

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #168 (87eff31) into master (ab3f0d4) will decrease coverage by 1.32%.
The diff coverage is 32.00%.

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
- Coverage   93.32%   91.99%   -1.33%     
==========================================
  Files          27       27              
  Lines         704      712       +8     
  Branches      295      296       +1     
==========================================
- Hits          657      655       -2     
- Misses         47       57      +10     

@hyochan hyochan added 🍗 enhancement New feature or request 🛠 bugfix All kinds of bug fixes labels Nov 10, 2021
@hyochan hyochan merged commit 767b180 into dooboolab-community:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 bugfix All kinds of bug fixes 🍗 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants