Resolve the NetworkImage issue on IOS #168
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NetworkImage had some issue about image on
ios
.Problem
renderImage
should renderurl
source AfterneedLoading
turns intofalse
inuseEffect
. ButrenderImage
shows a previous image(This caseloadingSource
) in a very short time before they finished to load url image. It was very short short moment, but It was clearly stood out. It may related this issue. So I give a key props torenderImage
, then solve the problem. Furthermore, I implemented memoization withuseCallback
anduseMemo
.Test Plan
N/A
Related Issues
Refer this issue
Tests
I added the following tests:
snapshot update
Checklist
Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.yarn test:all
and make sure nothing fails. You can runyarn test -u
to update snapshots if needed.