Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controllers inherit Doorkeeper::AppliactionMetalController #170

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

sato11
Copy link
Contributor

@sato11 sato11 commented Jul 6, 2022

This closes #169. Background is reasoned in the issue.

Initially I only wanted to raise discussion, but since I have already had a patch that can work for me I'm proceeding with opening a PR. What do you think? I appreciate any feedbacks 🙂

Copy link
Member

@nbulaj nbulaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me 👍

@nbulaj nbulaj merged commit f88678c into doorkeeper-gem:master Jul 13, 2022
@sato11 sato11 deleted the patch1 branch July 14, 2022 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shouldn't controllers inherit Doorkeeper::ApplicationMetalController?
2 participants