Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dookeeper-jwt compatibility #188

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Fix dookeeper-jwt compatibility #188

merged 1 commit into from
Feb 2, 2023

Conversation

zavan
Copy link
Contributor

@zavan zavan commented Feb 1, 2023 •
edited
Loading

Using this gem along with the doorkeeper-jwt gem caused problems because that gem defines a Doorkeeper::JWT constant, so the autoloader thinks it should load JWT::JWK and other constants under the JWT namespace from there since this gem is also under the Doorkeeper namespace. The solution is to prefix the JWT uses with ::.

Fixes #187.

@zavan
Copy link
Contributor Author

zavan commented Feb 1, 2023

Fixes #187.

@zavan zavan mentioned this pull request Feb 1, 2023
Closed
nbulaj
nbulaj approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@nbulaj nbulaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stupid error 😄
Thanks!

@nbulaj nbulaj merged commit 9de10c0 into doorkeeper-gem:master Feb 2, 2023
@zavan zavan deleted the fix-doorkeeper-jwt-compatibility branch February 2, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbulaj nbulaj nbulaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

uninitialized constant Doorkeeper::JWT::JWK in 1.8.4
2 participants
@zavan @nbulaj