-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression with Errors in 5.6.8 #1685
Comments
Hey @henrikbjorn . Unfortunately this is an expected behavior as we refactored gem internals. So I can suggest you to follow the new way how errors work. Can you please give more details about an error you're facing with the latest update and your gem? Maybe we can do some backward compatible changes to support something you (and maybe anyone else) need in your gem. Also will ping @camero2734 just in case |
It make sense that such a change would requiring changes to other gems, however I think it is a regression it was done in a minor release. I am getting a |
A mitigation could be to convert the symbol into the matching error class dynamically. eg. |
Seeing a similar issue while using
|
Hey @henrikbjorn . Yeah, looks like this. We have to check if |
Steps to reproduce
Do a clean install with Rails, latest Doorkeeper release and latest https://github.com/exop-group/doorkeeper-device_authorization_grant release.
commit that broke it: bdf3d50
Expected behavior
Should work without problems.
Actual behavior
Exception is raised since errors are now an object and not a simple Symbol. I would suspect this might have broken other gems aswell.
System configuration
You can help us to understand your problem if you will share some very
useful information about your project environment (don't forget to
remove any confidential data if it exists).
Doorkeeper initializer:
Ruby version:
3.2
Gemfile.lock:
Gemfile.lock content
The text was updated successfully, but these errors were encountered: