Define test factory classes using stringified class names #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
Hi @sman591 . Thanks for your work! Could you please add an entry to changelog (NEWS.md) and squash all the commits to a single one? |
As described in doorkeeper-gem#1043, factories defined by doorkeeper are unable to be loaded by host apps using the `factory_bot_rails` gem (receiving errors such as `uninitialized constant Doorkeeper::AccessGrant`) Documentation for factory_bot was later added to explain an easy fix for this: instead of defining the factory's `class: ` with a named constant, wrap the constant in a string. By doing so, the constant isn't evaluated until the factory actually runs, at which point the `Doorkeeper::` models have all been loaded. Fixes thoughtbot/factory_bot#1188
sman591
force-pushed
the
string-factories
branch
from
e90e70d
to
dc59f39
Compare
|
@nbulaj Added & squashed! Happy to reword news entry if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1043, factories defined by doorkeeper are unable to be loaded by host apps using the
factory_bot_railsgem (receiving errors such asuninitialized constant Doorkeeper::AccessGrant)Documentation for factory_bot was later added to explain an easy fix for this: instead of defining the factory's
class:with a named constant, wrap the constant in a string. By doing so, the constant isn't evaluated until the factory actually runs, at which point theDoorkeeper::models have all been loaded.Fixes thoughtbot/factory_bot#1188