Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scopes field accepts Array #1214

Merged
merged 1 commit into from
Mar 13, 2019
Merged

scopes field accepts Array #1214

merged 1 commit into from
Mar 13, 2019

Conversation

jasl
Copy link
Contributor

@jasl jasl commented Mar 11, 2019

Summary

Let scopes can accepts Array value, that useful to support select scopes checkbox like Gitlab

image

@jasl jasl force-pushed the support-write-scopes-with-array branch from b67bd52 to 8aaff1a Compare March 11, 2019 19:23
@nbulaj
Copy link
Member

nbulaj commented Mar 12, 2019

This one nice, @jasl ! Thanks!

Could you please rebase current master?

@jasl jasl force-pushed the support-write-scopes-with-array branch from 8aaff1a to a1428e5 Compare March 12, 2019 12:03
@jasl
Copy link
Contributor Author

jasl commented Mar 12, 2019

Rebased, wait CI pass

@jasl
Copy link
Contributor Author

jasl commented Mar 12, 2019

seems Hound hanging

@jasl jasl force-pushed the support-write-scopes-with-array branch from a1428e5 to 06e2b15 Compare March 12, 2019 20:10
@jasl
Copy link
Contributor Author

jasl commented Mar 12, 2019

@felipeelias refactored

felipeelias
felipeelias approved these changes Mar 12, 2019
View reviewed changes
Copy link
Member

@felipeelias felipeelias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@jasl
Copy link
Contributor Author

jasl commented Mar 13, 2019

CI failed on installing Ruby

@jasl
Copy link
Contributor Author

jasl commented Mar 13, 2019 

4.59s$ rvm use 2.6 --install --binary --fuzzy
curl: (22) The requested URL returned error: 404 Not Found
Required ruby-2.6 is not installed - installing.
curl: (22) The requested URL returned error: 404 Not Found
Searching for binary rubies, this might take some time.
Requested binary installation but no rubies are available to download, consider skipping --binary flag.
Gemset '' does not exist, 'rvm ruby-2.6 do rvm gemset create ' first, or append '--create'.
The command "rvm use 2.6 --install --binary --fuzzy" failed and exited with 2 during .

Weird, I'll look on it later.

@jasl
Copy link
Contributor Author

jasl commented Mar 13, 2019

I also found CI failed on master, so I do a workaround for 2.6, see #1217, if it pass and merge, I'll rebase this PR and try again

@nbulaj
Copy link
Member

nbulaj commented Mar 13, 2019

Merged, can rebase now :)

@jasl jasl force-pushed the support-write-scopes-with-array branch from 06e2b15 to 421be78 Compare March 13, 2019 08:42
@jasl
Copy link
Contributor Author

jasl commented Mar 13, 2019

@nbulaj finally...

@nbulaj nbulaj merged commit fe1378f into doorkeeper-gem:master Mar 13, 2019
@jasl jasl deleted the support-write-scopes-with-array branch March 13, 2019 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipeelias felipeelias felipeelias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasl @nbulaj @felipeelias