Skip to content
This repository has been archived by the owner on Sep 25, 2018. It is now read-only.

npm run build explodes #39

Closed
astra137 opened this issue Dec 9, 2017 · 6 comments
Closed

npm run build explodes #39

astra137 opened this issue Dec 9, 2017 · 6 comments
Assignees
@astra137
Labels
bug

Comments

@astra137
Copy link
Collaborator

astra137 commented Dec 9, 2017

Something with source maps is buggered and I cannot build feat/tags on Windows. Do you want me to look into this?
@puregarlic
Copy link
Member

Nah, I'll see what I can do

@puregarlic
Copy link
Member

@maccelerated, what are your steps to reproduce? I checked out the branch, installed dependencies, and ran yarn build and everything worked fine, no problems.

@puregarlic
Copy link
Member

Double-checked with npm run build, same thing.

@astra137
Copy link
Collaborator Author

I'll try again. Could have been something specific about the env.

@astra137
Copy link
Collaborator Author

Happens with latest feat/tags on macOS as well. I even rm -rf'd node_modules to make sure. Error: original.line and original.column are not numbers -- you probably meant to omit the original mapping entirely and only map the generated position. If so, pass null for the original mapping instead of an object with empty or null values.

@puregarlic
Copy link
Member

Looks like something similar is happening here: mozilla/source-map#304

@puregarlic puregarlic mentioned this issue Dec 14, 2017
Merged
@astra137 astra137 assigned astra137 and unassigned puregarlic Dec 14, 2017
@astra137 astra137 added the bug label Dec 14, 2017
astra137 pushed a commit that referenced this issue Dec 14, 2017
fix(build): Remove production source maps
3d25bfb 
Skip production source maps to avoid build error.

fix #39
puregarlic pushed a commit that referenced this issue Dec 18, 2017
@puregarlic
feat(tags): Add tags (#37)
a4cddaa 
* feat(tags): Add tags

Add tags with color changing. Tags store inside localStorage.

re #35

* refactor(Game.vue): Convert metadata area to form

Also cash in on some game/element state tech debt.

BREAKING CHANGE: localStorage.clear()

re #37

* fix(tags): Simplify tag popup and remove transitions

re #37

* fix(build): Remove production source maps

Skip production source maps to avoid build error.

fix #39

* chore(dependencies): Bump dependencies

* fix(elements): Set game.elements when removing elements

Ensure that data is being set instead of computed fields.

re #37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@astra137 astra137

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@puregarlic @astra137