This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
IdentifiedCommand replaced with ExistingCommandBehavior in MediatR pipeline #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename DuplicateCommand to ExistingCommand
|
Hi @domenkogler, this change seems interesting but the domain events processing pipeline had a significant overhaul to handle a set of issues, related to #700, so this code is highly outdated now. Anyway I'm not sure if it'd be a good idea to add the existing command behavior, because not all domain events are commands that need to have verified for uniqueness. In the future I'd recommend that before embarking in a PR of this magnitude, you begin a discussion with an issue and check with @CESARDELATORRE, because these changes also have to be reflected in the Microservices guide/e-book |
|
Closing this PR now but feel free to comment, will reopen if needed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IdentifiedCommand replaced with ExistingCommandBehavior in MediatR pipeline.
Implementing response for existing command is now simpler and actual command is passed as parameter.
Added Tests, also for ValidatorBehavior.
#661 Also contains #654