Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handlers and enhanced navigation 8.0 #30884

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Handlers and enhanced navigation 8.0 #30884

merged 4 commits into from
Oct 31, 2023

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Oct 31, 2023 •
edited by github-actions bot
Loading

Fixes #30876

Mackinnon ...

  • Seems like there were two paragraphs in the content that you supplied and one was more general than the other, so I placed one a little higher than the other.
  • Since these paragraphs refer to location changing handlers and that section was below the new content on enhanced nav, I moved the Location changes section above the new Enhanced navigation and form handling section.

❓Should the second paragraph end with a remark like ...

If the app must rely on a location change handler firing, don't use enhanced navigation, which is explained later in this section.

UPDATE: Yes! Let's give that line a try. You can let me know about keeping or 🔪 it on review.

Internal previews

📄 File 🔗 Preview link
aspnetcore/blazor/fundamentals/routing.md ASP.NET Core Blazor routing and navigation

@guardrex guardrex mentioned this pull request Oct 31, 2023
Closed
@guardrex guardrex self-assigned this Oct 31, 2023
MackinnonBuck
MackinnonBuck approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@MackinnonBuck MackinnonBuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@guardrex guardrex merged commit cc775be into main Oct 31, 2023
3 checks passed
@guardrex guardrex deleted the guardrex-patch-3 branch October 31, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MackinnonBuck MackinnonBuck MackinnonBuck approved these changes

Assignees

@guardrex guardrex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LocationChanged event and location changing handlers interaction with enhanced navigation 8.0
2 participants
@guardrex @MackinnonBuck