Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snippet cross-links 8.0 (2) #31274

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Snippet cross-links 8.0 (2) #31274

merged 2 commits into from
Dec 20, 2023

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Dec 20, 2023

Addresses #31029
Addresses #28161


Internal previews

Toggle expand/collapse
📄 File 🔗 Preview link
aspnetcore/blazor/components/cascading-values-and-parameters.md ASP.NET Core Blazor cascading values and parameters
aspnetcore/blazor/components/data-binding.md ASP.NET Core Blazor data binding
aspnetcore/blazor/components/dynamiccomponent.md Dynamically-rendered ASP.NET Core Razor components
aspnetcore/blazor/components/element-component-model-relationships.md Retain element, component, and model relationships in ASP.NET Core Blazor
aspnetcore/blazor/components/event-handling.md aspnetcore/blazor/components/event-handling
aspnetcore/blazor/components/index.md ASP.NET Core Razor components
aspnetcore/blazor/components/lifecycle.md ASP.NET Core Razor component lifecycle
aspnetcore/blazor/components/overwriting-parameters.md Avoid overwriting parameters in ASP.NET Core Blazor
aspnetcore/blazor/components/prerender.md aspnetcore/blazor/components/prerender
aspnetcore/blazor/components/quickgrid.md ASP.NET Core Blazor QuickGrid component
aspnetcore/blazor/components/sections.md ASP.NET Core Blazor sections
aspnetcore/blazor/components/templated-components.md ASP.NET Core Blazor templated components
aspnetcore/blazor/components/virtualization.md aspnetcore/blazor/components/virtualization
aspnetcore/blazor/debug.md Debug ASP.NET Core apps
aspnetcore/blazor/file-downloads.md ASP.NET Core Blazor file downloads
aspnetcore/blazor/file-uploads.md ASP.NET Core Blazor file uploads
aspnetcore/blazor/forms/binding.md aspnetcore/blazor/forms/binding
aspnetcore/blazor/forms/index.md ASP.NET Core Blazor forms overview
aspnetcore/blazor/forms/input-components.md ASP.NET Core Blazor input components
aspnetcore/blazor/forms/validation.md ASP.NET Core Blazor forms validation
aspnetcore/blazor/fundamentals/dependency-injection.md aspnetcore/blazor/fundamentals/dependency-injection
aspnetcore/blazor/fundamentals/index.md ASP.NET Core Blazor fundamentals
aspnetcore/blazor/globalization-localization.md ASP.NET Core Blazor globalization and localization
aspnetcore/blazor/javascript-interoperability/call-dotnet-from-javascript.md Call .NET methods from JavaScript functions in ASP.NET Core Blazor
aspnetcore/blazor/javascript-interoperability/call-javascript-from-dotnet.md Call JavaScript functions from .NET methods in ASP.NET Core Blazor
aspnetcore/blazor/javascript-interoperability/index.md aspnetcore/blazor/javascript-interoperability/index
aspnetcore/blazor/performance.md ASP.NET Core Blazor performance best practices
aspnetcore/blazor/security/index.md ASP.NET Core Blazor authentication and authorization
aspnetcore/blazor/security/server/index.md Secure ASP.NET Core server-side Blazor apps
aspnetcore/blazor/state-management.md aspnetcore/blazor/state-management

Note
This table shows preview links for the 30 files with the most changes. For preview links for other files in this PR, select OpenPublishing.Build Details within checks.

@guardrex
Copy link
Collaborator Author

@Rick-Anderson @wadepickett @tdykstra ... We're getting more "broken link" build issues for links that aren't broken. First, it was Docker Hub cross-links that were throwing 401, 404, and 405 GET errors on their page load. Apparently, the build system didn't like it too much because it threw the broken link warning on builds. I fixed those with a code-fenced link, and I opened an issue with the Docker Hub folks to ask them about their page errors and left a tracking HTML comment in our article(s). I'll return to the Docker Hub link situation in '24 and try to re-institute a normal markdown cross-link if they fix their page errors.

Today on this PR, it's throwing for Can I Use cross-links ...

Link 'https://caniuse.com/?search=websockets' points to a page that doesn't exist. Check the path or URL and update the link.

That page only seems to break here because MalwareBytes blocks the Google Tag Manager script that they're using. If the build system is also blocking that script, it might explain why it's reporting a broken link. I'm not going to try and address this. I'll let the warning go. However, it might be worth the SiteHelp folks looking at it to figure out exactly why it's throwing and to let us know. We could be seeing a pattern develop here, and it would be nice to understand what scenarios result in the build system choking on a link that really isn't broken.

@guardrex guardrex merged commit dc64c7d into main Dec 20, 2023
3 checks passed
@guardrex guardrex deleted the guardrex/blazor-sample-crosslinks branch December 20, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant