Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server-side behaviors during static SSR #32048

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Mar 13, 2024

Fixes #31402

Thanks @FengRuikai! 🚀

I'm mostly going off of Javier's sentiment expressed here ...

dotnet/aspnetcore#52176 (comment)

... and I'm cleaning up the approach for how we can convey this information:

  • Add the guidance to the static SSR section of the Render Modes article. Include how devs should deal with these scenarios server-side.
  • Clean up and cross-link that from the <NotAuthorized> content in the Security article.
  • Clean up and cross-link that from the <NotFound> content in the Routing and Layouts articles.

Also, are there any other scenarios that fall into this bucket outside of <NotFound> and <NotAuthorized> content that we should add to the list here (and cross-link from outside the article)?

... and btw ... you'll see a few other small wording changes ...

  • At the start of the Static server-side rendering (static SSR) section.
  • In the Static SSR components spread out across the app section.

Those updates are just things that I thought I could improve in passing. They don't pertain to the PR or the issue, but I recommend looking 👀 at those additional updates given the general complexity of the coverage.


Internal previews

📄 File 🔗 Preview link
aspnetcore/blazor/components/layouts.md ASP.NET Core Blazor layouts
aspnetcore/blazor/components/render-modes.md ASP.NET Core Blazor render modes
aspnetcore/blazor/fundamentals/routing.md ASP.NET Core Blazor routing and navigation
aspnetcore/blazor/security/index.md aspnetcore/blazor/security/index

Copy link
Member

@MackinnonBuck MackinnonBuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some smallish suggestions - might be good to get @javiercn's input before merging

aspnetcore/blazor/components/render-modes.md Outdated Show resolved Hide resolved
aspnetcore/blazor/components/render-modes.md Outdated Show resolved Hide resolved
aspnetcore/blazor/components/render-modes.md Outdated Show resolved Hide resolved
guardrex and others added 2 commits March 13, 2024 18:23
Co-authored-by: Mackinnon Buck <mackinnon.buck@gmail.com>
@guardrex
Copy link
Collaborator Author

guardrex commented Mar 18, 2024

No response to the ping. Let's go ahead and take reader feedback at this point. If anything is amiss, I'm sure that I'll hear about it ... readers will sharpen their BEAKS and CLAWS 🦅 for me 😨😆.

@guardrex guardrex merged commit 33c59c6 into main Mar 18, 2024
3 checks passed
@guardrex guardrex deleted the guardrex/blazor-render-mode-work branch March 18, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The content inside <NotAuthorized> tag in Routes component won't be displayed
2 participants