Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override InputNumber type attribute #33557

Merged
merged 8 commits into from
Sep 6, 2024

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Sep 6, 2024

Fixes #33556

Mackinnon ...

  • This covers both the 9.0 What's New article and the new section in the Input Components article.
  • Sorry that I replaced your example. I'm trying to go with Star Trek-themed forms throughout the Forms node.
  • Is there anything else that we need to tell devs in the article section?

Internal previews

📄 File 🔗 Preview link
aspnetcore/blazor/forms/input-components.md ASP.NET Core Blazor input components

@guardrex guardrex self-assigned this Sep 6, 2024
Copy link
Member

@MackinnonBuck MackinnonBuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the new example - it's more fun than the one I drafted up 🙂

However, I'm wondering if we should keep the docs for this feature a bit shorter. Overriding the type attribute on InputNumber is a pretty niche scenario that can likely be mentioned in passing rather than getting a section dedicated to it. Do you agree? I appreciate that it's a cool example, I'm just worried that it could make the docs a bit noisy when we're mostly trying to highlight the line(s) with <InputNumber type="range" />.

@MackinnonBuck
Copy link
Member

MackinnonBuck commented Sep 6, 2024

e.g., we could even just have a note somewhere like:

Note

The <InputNumber> component can also act as a range input by adding the type="range" attribute.

@guardrex
Copy link
Collaborator Author

guardrex commented Sep 6, 2024

I suppose so. We don't have a dedicated section for InputNumber, so I didn't have much choice if we wanted a full sample.

I'll see about knocking it down to something simple in the main coverage, and then I'll place a reduced full example component in the What's New coverage ... Star Trek, of course! 😆

@guardrex
Copy link
Collaborator Author

guardrex commented Sep 6, 2024

Nevermind ... I had time now to adjust it before leaving. Try it now.

@guardrex
Copy link
Collaborator Author

guardrex commented Sep 6, 2024

Ok ... I'm done mess'in around with it. 😆

@guardrex
Copy link
Collaborator Author

guardrex commented Sep 6, 2024

@MackinnonBuck ... See if that (finally 🙈) gets it.

I have 🍺 in the fridge. Maybe I need to drink one ............ or FIVE! 😆

@MackinnonBuck
Copy link
Member

Looks great!

@guardrex guardrex merged commit 2e5e099 into main Sep 6, 2024
3 checks passed
@guardrex guardrex deleted the guardrex/blazor-override-inputnumber-type-attr branch September 6, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Override InputNumber type attribute
2 participants