Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR builds should not be published to BDN nightly feed #1922

Closed
mawosoft opened this issue Feb 13, 2022 · 3 comments · Fixed by mawosoft/Mawosoft.Extensions.BenchmarkDotNet#28
Closed

PR builds should not be published to BDN nightly feed #1922

mawosoft opened this issue Feb 13, 2022 · 3 comments · Fixed by mawosoft/Mawosoft.Extensions.BenchmarkDotNet#28
Assignees
@AndreyAkinshin

Comments

@mawosoft
Copy link
Contributor

As the title says.

Currently, the latest version on the nightly feed is 0.13.1.1697, which comes from an unmerged PR that inadvertently reverts changes already commited to master. The version before, 0.13.1.1696, is actually the most recent build from master (at the time I'm writing this, of course).

I would do a PR to fix this myself, but this is probably an AppVeyor settings thing I haven't access to.
@adamsitnik
Copy link
Member

@AndreyAkinshin could you please take a look?

mawosoft added a commit to mawosoft/Mawosoft.Extensions.BenchmarkDotNet that referenced this issue Feb 14, 2022
@mawosoft
Pin NightlyBDN version
0420b9e 
See dotnet/BenchmarkDotNet#1922
[skip ci]
@AndreyAkinshin AndreyAkinshin self-assigned this Feb 14, 2022
@AndreyAkinshin
Copy link
Member

@mawosoft thanks for reporting this! Should be fixed now.
image

mawosoft added a commit to mawosoft/Mawosoft.Extensions.BenchmarkDotNet that referenced this issue Feb 15, 2022
@mawosoft
ConfigExtensions: Tolerate both implementation and breaking API chang…
4d598df 
…es in BDN-nightly > 0.13.1.

- Tolerate implementation changes in ManualConfig.GetXxx() Closes #25.
- Tolerate breaking API changes in BenchmarkReport.ctor() and others. See #26.
- Unpin NightlyBDN (Issue resolved dotnet/BenchmarkDotNet#1922).
- Add tests.
@mawosoft mawosoft mentioned this issue Feb 15, 2022
Merged
@mawosoft
Copy link
Contributor Author

mawosoft commented Mar 9, 2022

@AndreyAkinshin , @adamsitnik
This still seems to happen. PR #1935 just published version 0.13.1.1707 on the AppVeyor feed.

@mawosoft mawosoft mentioned this issue Mar 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreyAkinshin AndreyAkinshin

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@AndreyAkinshin @adamsitnik @mawosoft