Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting affinity does not work for Environment.ProcessorCount >= 32 #2211

Closed
Donis- opened this issue Dec 1, 2022 · 2 comments
Closed

Setting affinity does not work for Environment.ProcessorCount >= 32 #2211

Donis- opened this issue Dec 1, 2022 · 2 comments
Assignees
@Donis-
Milestone
v0.13.3

Comments

@Donis-
Copy link
Contributor

Donis- commented Dec 1, 2022

https://github.com/dotnet/BenchmarkDotNet/blob/master/src/BenchmarkDotNet/Extensions/ProcessExtensions.cs#L48

int cpuMask = (1 << Environment.ProcessorCount)
becomes 0 for Environment.ProcessorCount >=32

This works:
long cpuMask = (1L << Environment.ProcessorCount) - 1;
@timcassell
Copy link
Collaborator

Affinity is a bit mask, so it will only work up to 64 cores? We already have processors with more threads than that...

Donis- added a commit to Donis-/BenchmarkDotNet that referenced this issue Dec 9, 2022
@Donis-
Increase max supported affinity from 31 to 64 (dotnet#2211)
b0ebf7a
Donis- added a commit to Donis-/BenchmarkDotNet that referenced this issue Dec 9, 2022
@Donis-
Increase max supported affinity from 31 to 64 (dotnet#2211)
c99c0e2
adamsitnik pushed a commit that referenced this issue Dec 16, 2022
@Donis-
Increase max supported affinity from 31 to 64 (#2211) (#2228)
bf8b531
@adamsitnik adamsitnik added this to the v0.13.3 milestone Dec 16, 2022
@adamsitnik
Copy link
Member

Fixed by #2228

@huoyaoyuan huoyaoyuan mentioned this issue May 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Donis- Donis-

Labels
None yet
Projects
None yet
Milestone
v0.13.3
Development

No branches or pull requests
3 participants
@adamsitnik @Donis- @timcassell