-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change tracker docs #2972
Change tracker docs #2972
Conversation
8573cf9
to
a67d5c9
Compare
@dotnet/efteam The "estimated time to read" for all this is just over 2 hours. But you guys are fast readers, right? 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor questions and fixes.
> [!TIP] | ||
> You can run and debug into all the code in this document by [downloading the sample code from GitHub](https://github.com/dotnet/EntityFramework.Docs/tree/master/samples/core/ChangeTracking/ChangeTrackingInEFCore). | ||
|
||
> [!TIP] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a tip or a note?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we pretty consistently use Tip for this. However, not against changing it everywhere if Note is more appropriate. /cc @dotnet/efteam
|
||
Running this code results in the following exception: | ||
|
||
> System.InvalidOperationException: The instance of entity type 'Blog' cannot be tracked because another instance with the key value '{Id: 1}' is already being tracked. When attaching existing entities, ensure that only one entity instance with a given key value is attached. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be monospaced, i.e. surrounded with backticks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it reads better like this, but happy to change if the team agrees.
/cc @dotnet/efteam
69330a3
to
e6628b0
Compare
Change tracker docs
Fixes #2725
Fixes #2707
Fixes #2525
Fixes #2524
Fixes #2331
Fixes #2105
Fixes #2076
Fixes #1541
Fixes #1489
Fixes #1453
Fixes #1398
Fixes #1339
Fixes #1235
Fixes #1007
Fixes #863
Fixes #815
Fixes #786
Fixes #531
Fixes #505