Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tracker docs #2972

Merged
merged 8 commits into from
Jan 6, 2021
Merged

Change tracker docs #2972

merged 8 commits into from
Jan 6, 2021

Conversation

ajcvickers
Copy link
Member

@ajcvickers ajcvickers commented Dec 30, 2020

Change tracker docs

Fixes #2725
Fixes #2707
Fixes #2525
Fixes #2524
Fixes #2331
Fixes #2105
Fixes #2076
Fixes #1541
Fixes #1489
Fixes #1453
Fixes #1398
Fixes #1339
Fixes #1235
Fixes #1007
Fixes #863
Fixes #815
Fixes #786
Fixes #531
Fixes #505

@ajcvickers ajcvickers force-pushed the TrackMyHat1110 branch 3 times, most recently from 8573cf9 to a67d5c9 Compare December 30, 2020 23:55
@ajcvickers ajcvickers marked this pull request as draft December 31, 2020 01:03
@ajcvickers ajcvickers marked this pull request as ready for review December 31, 2020 22:18
@ajcvickers ajcvickers requested a review from a team December 31, 2020 22:18
@ajcvickers
Copy link
Member Author

@dotnet/efteam The "estimated time to read" for all this is just over 2 hours. But you guys are fast readers, right? 😉

Copy link
Member

@JeremyLikness JeremyLikness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor questions and fixes.

entity-framework/core/change-tracking/explicit-tracking.md Outdated Show resolved Hide resolved
> [!TIP]
> You can run and debug into all the code in this document by [downloading the sample code from GitHub](https://github.com/dotnet/EntityFramework.Docs/tree/master/samples/core/ChangeTracking/ChangeTrackingInEFCore).

> [!TIP]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a tip or a note?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we pretty consistently use Tip for this. However, not against changing it everywhere if Note is more appropriate. /cc @dotnet/efteam

entity-framework/core/change-tracking/explicit-tracking.md Outdated Show resolved Hide resolved
entity-framework/core/change-tracking/change-detection.md Outdated Show resolved Hide resolved
entity-framework/core/change-tracking/change-detection.md Outdated Show resolved Hide resolved

Running this code results in the following exception:

> System.InvalidOperationException: The instance of entity type 'Blog' cannot be tracked because another instance with the key value '{Id: 1}' is already being tracked. When attaching existing entities, ensure that only one entity instance with a given key value is attached.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be monospaced, i.e. surrounded with backticks?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it reads better like this, but happy to change if the team agrees.
/cc @dotnet/efteam

entity-framework/core/change-tracking/miscellaneous.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment