Remove warnings #3993
Merged
Remove warnings #3993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
approved these changes
Aug 22, 2022
smitpatel
commented
Aug 22, 2022
| # Card | ||
| - title: "Explore other options for .NET Data" | ||
| itemType: reference | ||
| url: dotnet-data | ||
| url: dotnet-data/index.yml |
There was a problem hiding this comment.
This file needs exact file URL. Earlier it was the folder. Which in web world, tries to go to index.* and it worked by accident.
smitpatel
commented
Aug 22, 2022
| @@ -411,7 +411,7 @@ | |||
| href: core/cli/services.md | |||
|
|
|||
| - name: EF Core API reference >> | |||
| href: /dotnet/api/?view=efcore-6.0 | |||
| href: /dotnet/api/?view=efcore-6.0&preserve-view=true | |||
There was a problem hiding this comment.
They recommend not using the version in URL string so it can go to latest by default but since it is a shared docset there is no way for us to specify efcore without using the version (monikers are tied to version). So the later arg explicitly state that we want 6.0 version and don't generate warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.