Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify event tracing #1188

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Simplify event tracing #1188

merged 1 commit into from
Aug 4, 2021

Conversation

Wraith2
Copy link
Contributor

@Wraith2 Wraith2 commented Jul 25, 2021

This replaces a lot of try finally blocks used to implement log traces with using blocks that do the same. This makes the code visually cleaner. There are a couple of minor style changes scattered around as well but there are no functional changes.

@cheenamalhotra cheenamalhotra added this to the 4.0.0-preview1 milestone Jul 28, 2021
Copy link
Member

@cheenamalhotra cheenamalhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very helpful @Wraith2 ❤️

@cheenamalhotra cheenamalhotra merged commit 83b8421 into dotnet:main Aug 4, 2021
@Wraith2 Wraith2 deleted the add-logscopes branch August 4, 2021 20:52
@cheenamalhotra cheenamalhotra added the ➕ Code Health Changes related to source code improvements label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
➕ Code Health Changes related to source code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants