Cleanup StringsHelper #1236
Merged
Cleanup StringsHelper #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cheenamalhotra
commented
Aug 30, 2021
cheenamalhotra
commented
- Remove unreferenced strings added in FIX | Add Component Model annotations to SqlConnectionStringBuilder class in netcore's src folder #1152
- File touch-ups.
cheenamalhotra
added
the
➕ Code Health
|
Nice. I like PR's which are deleting lots of things. 😁 |
|
I would have liked it to be cleaned in the initial PR itself but I was too busy with other things, didn't get time to dig in review for the second time.. so this one was on me! |
src/Microsoft.Data.SqlClient/netcore/src/Resources/StringsHelper.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Resources/StringsHelper.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
DavoudEshtehari
approved these changes
Sep 16, 2021
Kaur-Parminder
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.