Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Active Directory Default authentication improvements #1360

Merged
merged 5 commits into from
Oct 20, 2021
Merged

Active Directory Default authentication improvements #1360

merged 5 commits into from
Oct 20, 2021

Conversation

cheenamalhotra
Copy link
Member

@cheenamalhotra cheenamalhotra commented Oct 19, 2021 •
edited
Loading

Addresses #1332 and other improvements:

  • Rename tenantId to audience as the parameters accept broader values than GUID tenant Id.
  • Set Credential Options optionally only when valid data is available, allows users to specify Environment variables
  • Test case added for Kusto Samples DB.

cc @David-Engel

@cheenamalhotra cheenamalhotra added this to the 4.0.0-preview3 milestone Oct 19, 2021
@cheenamalhotra cheenamalhotra linked an issue Oct 19, 2021 that may be closed by this pull request
ActiveDirectoryDefault authentication ignores environment variables used by DefaultAzureCredential #1332
Closed
@cheenamalhotra cheenamalhotra mentioned this pull request Oct 19, 2021
Closed
@JRahnama
Copy link
Member

LGTM. Just a minor suggestion.

cheenamalhotra and others added 2 commits October 19, 2021 20:15
@cheenamalhotra @JRahnama
Update src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Acti…
db9cde1 
…veDirectoryAuthenticationProvider.cs

Co-authored-by: Javad <v-jarahn@microsoft.com>
@cheenamalhotra
Add configureawaits
8afbaff
@johnnypham johnnypham merged commit 3c8ef33 into dotnet:main Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smichtch smichtch smichtch left review comments

@johnnypham johnnypham johnnypham approved these changes

@lcheunglci lcheunglci lcheunglci approved these changes

@JRahnama JRahnama JRahnama approved these changes

@DavoudEshtehari DavoudEshtehari DavoudEshtehari approved these changes

@Kaur-Parminder Kaur-Parminder Awaiting requested review from Kaur-Parminder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0-preview3
Development

Successfully merging this pull request may close these issues.

ActiveDirectoryDefault authentication ignores environment variables used by DefaultAzureCredential
6 participants
@cheenamalhotra @JRahnama @smichtch @johnnypham @lcheunglci @DavoudEshtehari