Share SqlBuffer #1438
Merged
Share SqlBuffer #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavoudEshtehari
requested review from
JRahnama,
Kaur-Parminder and
DavoudEshtehari
|
The failures don't appear related to my changes, can someone re-run the failed legs? |
DavoudEshtehari
added
the
➕ Code Health
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs
Outdated
Show resolved
Hide resolved
|
can you address the conflicts here please? |
Wraith2
force-pushed
the
port-datetimespanify
branch
from
dea707b
to
5cfd6dd
Compare
|
Done. |
JRahnama
reviewed
Feb 23, 2022
| _isNull = false; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
instead of doing this could not we have #if directive inside one class? this creates a new file again for netfx.
There was a problem hiding this comment.
We could but it would be inconsistent with the approach I've previously been asked to use. The approach has been to use conditional elements within the project file and avoid #ifdef blocks in individual files favouring totally separate files where possible.
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParserStateObject.cs
Outdated
Show resolved
Hide resolved
JRahnama
approved these changes
Feb 23, 2022
johnnypham
reviewed
Apr 1, 2022
src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj
Outdated
Show resolved
Hide resolved
Wraith2
force-pushed
the
port-datetimespanify
branch
from
3b46c82
to
8b35520
Compare
|
Rebased and fixed. Please don't make me to this a third time. |
johnnypham
approved these changes
Apr 4, 2022
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlBuffer.netfx.cs
Outdated
Show resolved
Hide resolved
DavoudEshtehari
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the changes from dotnet/corefx#31044 to netfx. It then shares the resulting SqlBuffer file and uses a SqlBuffer.netfx.cs file to contain the netfx (legacy) methods required for v200 smi support.
@DavoudEshtehari this adds to the codebase merging