Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change | Using default system protocols for TDS8 on Managed code #1678

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Change | Using default system protocols for TDS8 on Managed code #1678

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c54d6c0
Using default system protocols for TDS8 on Managed code
JRahnama Jul 22, 2022
c0a1809
Review comments
JRahnama Jul 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNIHandle.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ namespace Microsoft.Data.SqlClient.SNI
internal abstract class SNIHandle
{
/// <summary>
/// Exclude TLS 1.3 (not fully supported).
/// Exclude TLS 1.3 in TLS-over-TDS modes (TDS 7.4 and below)
/// </summary>
protected static readonly SslProtocols s_supportedProtocols = LocalAppContextSwitches.UseSystemDefaultSecureProtocols ? SslProtocols.None : SslProtocols.Tls12 | SslProtocols.Tls11 | SslProtocols.Tls
//protected readonly SslProtocols SupportedProtocols = SslProtocols.Tls12 | SslProtocols.Tls11 | SslProtocols.Tls
Expand All @@ -36,7 +36,6 @@ protected static async Task AuthenticateAsClientAsync(SslStream sslStream, strin
{
DavoudEshtehari marked this conversation as resolved.
Show resolved Hide resolved
TargetHost = serverNameIndication,
ApplicationProtocols = s_tdsProtocols,
EnabledSslProtocols = s_supportedProtocols,
ClientCertificates = certificate
};
await sslStream.AuthenticateAsClientAsync(sslClientOptions, token);
Expand Down