Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release | Updating SNI version for 5.1.0-preview1 release #1787

Merged
merged 2 commits into from
Oct 6, 2022

Conversation

JRahnama
Copy link
Member

@JRahnama JRahnama commented Oct 5, 2022

No description provided.

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 71.47% // Head: 71.37% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (8d79ba0) compared to base (ac7c1a4).
Patch coverage: 74.53% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1787      +/-   ##
==========================================
- Coverage   71.47%   71.37%   -0.11%     
==========================================
  Files         292      290       -2     
  Lines       61302    61109     -193     
==========================================
- Hits        43814    43614     -200     
- Misses      17488    17495       +7     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 74.96% <78.74%> (-0.12%) ⬇️
netfx 69.23% <54.32%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/Microsoft/Data/SqlClient/TdsParserSessionPool.cs 86.25% <22.22%> (ø)
.../Microsoft/Data/SqlClient/SqlInternalConnection.cs 72.77% <58.33%> (ø)
...core/src/Microsoft/Data/SqlClient/SqlDataReader.cs 72.79% <91.66%> (-0.06%) ⬇️
.../src/Microsoft/Data/SqlClient/AAsyncCallContext.cs 91.42% <95.45%> (+3.92%) ⬆️
...netcore/src/Microsoft/Data/SqlClient/SqlCommand.cs 83.46% <97.05%> (-0.26%) ⬇️
...re/src/Microsoft/Data/SqlClient/SNI/SNINpHandle.cs 68.85% <0.00%> (-9.84%) ⬇️
...nt/src/Microsoft/Data/ProviderBase/TimeoutTimer.cs 78.57% <0.00%> (-3.58%) ⬇️
...c/Microsoft/Data/SqlClient/SqlConnectionFactory.cs 68.85% <0.00%> (-0.82%) ⬇️
...rc/Microsoft/Data/ProviderBase/DbConnectionPool.cs 85.19% <0.00%> (-0.67%) ⬇️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JRahnama JRahnama merged commit fe8d1c1 into dotnet:main Oct 6, 2022
@JRahnama JRahnama deleted the preview1-release branch October 31, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants