Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0.2] Fix | TDS RPC error on large queries in SqlCommand.ExecuteReaderAsync #1976

Merged

Conversation

lcheunglci
Copy link
Contributor

Backporting the fix to the 5.0-servicing branch. This fixes the TDS RPC error on large queries in SqlCommand.ExecuteReaderAysnc and these changes are based on #1936

@lcheunglci lcheunglci added this to the 5.0.2 milestone Mar 30, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.23 ⚠️

Comparison is base (4031ef9) 71.63% compared to head (e0f0056) 71.40%.

Additional details and impacted files
@@                Coverage Diff                @@
##           5.0-servicing    #1976      +/-   ##
=================================================
- Coverage          71.63%   71.40%   -0.23%     
=================================================
  Files                293      293              
  Lines              61377    61377              
=================================================
- Hits               43965    43824     -141     
- Misses             17412    17553     +141     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 75.01% <ø> (-0.24%) ⬇️
netfx 69.22% <100.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs 70.98% <100.00%> (-0.43%) ⬇️

... and 21 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lcheunglci lcheunglci merged commit bf93b16 into dotnet:5.0-servicing Mar 30, 2023
@lcheunglci lcheunglci deleted the 5.0-Backport-1936-TDS-RPC-Fix branch March 30, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants