Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix | Fix issue with SqlCommand OnStatementCompleted event not being triggered #216

Merged
merged 5 commits into from
Sep 26, 2019
Merged

Fix | Fix issue with SqlCommand OnStatementCompleted event not being triggered #216

merged 5 commits into from
Sep 26, 2019

Conversation

cheenamalhotra
Copy link
Member

Fixes issue #212

@Charles-Gagnon
Please verify the fix and let us know.

  • Also added test to verify the same.

@Charles-Gagnon
Copy link

Awesome, thanks! Do you have a build I can use? Otherwise I'll grab one from these validation builds when they complete and let you know if it solves our issue.

@cheenamalhotra
Copy link
Member Author

Microsoft.Data.SqlClient.PR216.zip
You may try this NuGet package that contains the fix.

@cheenamalhotra cheenamalhotra added this to the 1.1.0-preview1 milestone Sep 25, 2019
@cheenamalhotra cheenamalhotra mentioned this pull request Sep 25, 2019
Merged
@cheenamalhotra cheenamalhotra added the 📍 Push to Commit Feed This label will be added to PRs whose NuGet Package will be available from CI Public Feed. label Sep 26, 2019
@cheenamalhotra cheenamalhotra merged commit aa56756 into dotnet:master Sep 26, 2019
@cheenamalhotra cheenamalhotra deleted the fix212 branch September 26, 2019 20:43
@cheenamalhotra
Copy link
Member Author

NuGet Package for validation:
Microsoft.Data.SqlClient.Commits.1.1.0-build.19269.1-aa56756

yukiwongky pushed a commit to yukiwongky/SqlClient that referenced this pull request Nov 5, 2019
@cheenamalhotra
Fix | Fix issue with SqlCommand OnStatementCompleted event not being …
3ed8f60 
…triggered (dotnet#216)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wraith2 Wraith2 Wraith2 left review comments

@David-Engel David-Engel David-Engel approved these changes

Assignees
No one assigned
Labels
📍 Push to Commit Feed This label will be added to PRs whose NuGet Package will be available from CI Public Feed.
Projects
None yet
Milestone
1.1.0-preview1
Development

Successfully merging this pull request may close these issues.
4 participants
@cheenamalhotra @Charles-Gagnon @Wraith2 @David-Engel