Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tests to use connection string builder #229

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

Wraith2
Copy link
Contributor

@Wraith2 Wraith2 commented Sep 27, 2019

A couple of tests were using string concatenation to enable encryption on the connection string. This is ok unless your connection string isn't semicolon terminated, In that case the test fails with this sort of error:

  X Microsoft.Data.SqlClient.ManualTesting.Tests.AlwaysEncrypted.ApiShould.TestSqlDataAdapterFillDataTable [34ms]
  Error Message:
   System.ArgumentException : Invalid value for key 'connect timeout'.
---- System.FormatException : Input string was not in a correct format.
  Stack Trace:

This fixes the tests that do this by using a connection string builder as is used elsewhere in the tests to change connection properties.

Copy link
Contributor

@David-Engel David-Engel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cheenamalhotra cheenamalhotra added this to the 1.1.0-preview1 milestone Sep 27, 2019
@cheenamalhotra cheenamalhotra merged commit c00144f into dotnet:master Sep 27, 2019
@Wraith2 Wraith2 deleted the fix-constrconcat branch September 27, 2019 18:07
yukiwongky pushed a commit to yukiwongky/SqlClient that referenced this pull request Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants