Fix transient fault handling for Pooled connections #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
requested review from
karinazhou,
DavoudEshtehari,
johnnypham and
JRahnama
JRahnama
approved these changes
Jul 8, 2020
|
Logic wise LGM, but how can we test transient errors? Is it possible to have tests to do so? |
|
Transient errors occur on Database side, so I don't think we can trigger faults on server side. |
karinazhou
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All versions of SqlClient (including System.Data.SqlClient) that support Transient Fault Handling do not reset the connection before retrying for transient fault handling cases and if Azure connections fail to connect first time due to server timeout, the next round of connect fails with below error:
When pooling is disabled, apps are able to connect with Transient Fault Handling.
The PR fixes this issue for pooled connections.
NuGet package for testing: Published Artifacts