Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate CacheConnectionStringProperties calls #683

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ private static readonly ConcurrentDictionary<string, IList<string>> _ColumnEncry
public SqlConnection(string connectionString) : this()
{
ConnectionString = connectionString; // setting connection string first so that ConnectionOption is available
CacheConnectionStringProperties();
}

/// <include file='../../../../../../../doc/snippets/Microsoft.Data.SqlClient/SqlConnection.xml' path='docs/members[@name="SqlConnection"]/ctorConnectionStringCredential/*' />
Expand Down Expand Up @@ -157,7 +156,6 @@ public SqlConnection(string connectionString, SqlCredential credential) : this()
// else
cheenamalhotra marked this conversation as resolved.
Show resolved Hide resolved
// credential == null: we should not set "Credential" as this will do additional validation check and
// checking pool groups which is not necessary. All necessary operation is already done by calling "ConnectionString = connectionString"
CacheConnectionStringProperties();
}

private SqlConnection(SqlConnection connection)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,6 @@ public SqlConnection(string connectionString, SqlCredential credential) : this()
// else
cheenamalhotra marked this conversation as resolved.
Show resolved Hide resolved
// credential == null: we should not set "Credential" as this will do additional validation check and
// checking pool groups which is not necessary. All necessary operation is already done by calling "ConnectionString = connectionString"
CacheConnectionStringProperties();
}

private SqlConnection(SqlConnection connection)
Expand Down Expand Up @@ -3231,5 +3230,3 @@ internal struct MEMMAP
internal byte[] rgbData;
}
} // Microsoft.Data.SqlClient namespace