Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix | Perform Null check for SqlErrors in SqlException #698

Merged
merged 2 commits into from
Aug 21, 2020
Merged

Fix | Perform Null check for SqlErrors in SqlException #698

merged 2 commits into from
Aug 21, 2020

Conversation

cheenamalhotra
Copy link
Member

Fixes #677

@cheenamalhotra cheenamalhotra added this to the 2.1.0-preview1 milestone Aug 19, 2020
DavoudEshtehari
DavoudEshtehari approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@DavoudEshtehari DavoudEshtehari left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also update documentation for the effect of default values?
Also, in some cases like State using default value doesn't make sense since it keeps the status of something, not just a plain byte.
In my opinion, It can be a source of a conceptual bug in the future.

@cheenamalhotra
Copy link
Member Author

Regarding SqlState "default" value, I think we could address it when implementing #648 .
Other changes addressed.

@cheenamalhotra cheenamalhotra merged commit e10b230 into dotnet:master Aug 21, 2020
TrayanZapryanov pushed a commit to TrayanZapryanov/SqlClient that referenced this pull request Aug 31, 2020
@cheenamalhotra @TrayanZapryanov
Fix | Perform Null check for SqlErrors in SqlException (dotnet#698)
bddefe8
TrayanZapryanov added a commit to TrayanZapryanov/SqlClient that referenced this pull request Aug 31, 2020
@TrayanZapryanov
Revert "Fix | Perform Null check for SqlErrors in SqlException (dotne…
cb45d8f 
…t#698)"

This reverts commit bddefe8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnypham johnnypham johnnypham approved these changes

@karinazhou karinazhou karinazhou approved these changes

@JRahnama JRahnama JRahnama approved these changes

@DavoudEshtehari DavoudEshtehari DavoudEshtehari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0-preview1
Development

Successfully merging this pull request may close these issues.

System.ArgumentOutOfRangeException on ".ToString()" of SqlException
5 participants
@cheenamalhotra @johnnypham @karinazhou @JRahnama @DavoudEshtehari