Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync similar elements Enclaves #887

Merged
merged 7 commits into from
Mar 18, 2021
Merged

Conversation

Wraith2
Copy link
Contributor

@Wraith2 Wraith2 commented Jan 18, 2021

A set of changes to being netcore and netfx closer to parity without changing functionality. Mostly reformatting to the same ruleset and then moving shared core to the shared location.

Observations:

  1. netfx uses Cng classes directly but since Cng is the underlying implementation we could use the cross platform version on all targets without any change in functionality. I haven't done this but I think it's strongly worth considering.
  2. I changed the CombineByteArrays function to two separate functions because the allocation of a byte[][] each time it was called bothered my optimization sensibilities.
  3. a lot of the code dealing with hashes and keys could be made simpler using Memory refering to the the original blob if escape analysis proved the lifetimes were closed (and copies made if needed on a late bound basis) and if the code is used often enough for that to be worthwhile.

Base automatically changed from master to main March 15, 2021 17:54
@cheenamalhotra cheenamalhotra added this to the 3.0.0-preview2 milestone Mar 18, 2021
@cheenamalhotra cheenamalhotra merged commit 3943647 into dotnet:main Mar 18, 2021
@Wraith2 Wraith2 deleted the combine15 branch March 19, 2021 12:17
@Wraith2 Wraith2 mentioned this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants