Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not instantiate multiple Random instances within SqlFixedIntervalEnumerator #996

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Do not instantiate multiple Random instances within SqlFixedIntervalEnumerator #996

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ft.Data.SqlClient/src/Microsoft/Data/SqlClient/Reliability/SqlRetryIntervalEnumerators.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ internal class SqlFixedIntervalEnumerator : SqlRetryIntervalBaseEnumerator
{
private readonly int maxRandom;
private readonly int minRandom;
private readonly Random random = new Random();

public SqlFixedIntervalEnumerator(TimeSpan gapTimeInterval, TimeSpan maxTimeInterval, TimeSpan minTimeInterval)
: base(gapTimeInterval, maxTimeInterval, minTimeInterval)
Expand All @@ -94,7 +95,6 @@ public SqlFixedIntervalEnumerator(TimeSpan gapTimeInterval, TimeSpan maxTimeInte

protected override TimeSpan GetNextInterval()
{
var random = new Random();
Current = TimeSpan.FromMilliseconds(random.Next(minRandom, maxRandom));
return Current;
}
Expand Down