Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit warning for use of $(AotAssemblies) in .NET 7 #7297

Closed
jonathanpeppers opened this issue Aug 22, 2022 · 0 comments · Fixed by #7344
Closed

Emit warning for use of $(AotAssemblies) in .NET 7 #7297

jonathanpeppers opened this issue Aug 22, 2022 · 0 comments · Fixed by #7344
Assignees
@jonathanpeppers
Labels
Area: App+Library Build Issues when building Library projects or Application projects. enhancement Proposed change to current functionality.
Milestone
.NET 7 Servicing

Comments

@jonathanpeppers
Copy link
Member

Android application type

Android for .NET (net6.0-android, etc.)

Affected platform version

.NET 7+

Description

Context: #7295

The way we support $(AotAssemblies) requires us to know the names of packs in the Mono workload.

Let's drop support for $(AotAssemblies) and use the new $(RunAOTCompilation) property instead.

We can begin by emitting a warning in .NET 7.

Steps to Reproduce

  1. dotnet new android
  2. dotnet build -c Release -p:AotAssemblies=true
  3. Should emit a warning

Did you find any workaround?

No response

Relevant log output

No response
@jonathanpeppers jonathanpeppers added enhancement Proposed change to current functionality. Area: App+Library Build Issues when building Library projects or Application projects. labels Aug 22, 2022
@jonathanpeppers jonathanpeppers added this to the .NET 7 milestone Aug 22, 2022
@jonathanpeppers jonathanpeppers self-assigned this Aug 22, 2022
@jonathanpeppers jonathanpeppers mentioned this issue Aug 22, 2022
Merged
jonathanpeppers added a commit to jonathanpeppers/xamarin-android that referenced this issue Sep 6, 2022
@jonathanpeppers
[One .NET] add XA1029 for $(AotAssemblies)
0ae2308 
Fixes: dotnet#7297

The way we support `$(AotAssemblies)` requires us to *know* the names
of packs in the Mono workload.

Let's drop support for `$(AotAssemblies)` and use the new
`$(RunAOTCompilation)` property instead. We can begin by emitting a
warning in .NET 7, to potentially remove/error in .NET 8.
@jonathanpeppers jonathanpeppers mentioned this issue Sep 6, 2022
Merged
jonathanpeppers added a commit to jonathanpeppers/xamarin-android that referenced this issue Sep 7, 2022
@jonathanpeppers
[One .NET] add XA1029 for $(AotAssemblies)
525f408 
Fixes: dotnet#7297

The way we support `$(AotAssemblies)` requires us to *know* the names
of packs in the Mono workload.

Let's drop support for `$(AotAssemblies)` and use the new
`$(RunAOTCompilation)` property instead. We can begin by emitting a
warning in .NET 7, to potentially remove/error in .NET 8.
@ghost ghost locked as resolved and limited conversation to collaborators Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jonathanpeppers jonathanpeppers

Labels
Area: App+Library Build Issues when building Library projects or Application projects. enhancement Proposed change to current functionality.
Projects
None yet
Milestone
.NET 7 Servicing
Development

Successfully merging a pull request may close this issue.

[One .NET] add XA1029 for $(AotAssemblies) jonathanpeppers/xamarin-android
1 participant
@jonathanpeppers