[Xamarin.Android.Build.Tasks] Use binutils for Aot and LLVM #6901

pjcollins · 2022-04-06T20:58:01Z

It appears that an Android NDK installation is no longer needed when
using Aot with LLVM. Projects which enable Aot and LLVM will no longer
attempt to use the NDK unless it is explicitly requested by setting
$(AndroidNdkDirectory) to a valid NDK path in the project file.

src/Xamarin.Android.Build.Tasks/Tasks/GetAotArguments.cs

jonathanpeppers

After we merge this, is it worth making the lookup of the NDK in xamarin-android-tools optional?

I haven't measured, but surely some amount of milliseconds probing for NDKs, and we could skip that now?

jonathanpeppers · 2022-05-05T19:51:03Z

Oh, I see the do-not-merge label now. Is there an issue?

pjcollins · 2022-05-05T20:31:22Z

Oh, I see the do-not-merge label now. Is there an issue?

I think there are still a couple of test failures using the latest Android NDK when LLVM is disabled, but I wanted to open this up for review on the general approach of the changes. I'm wondering if we should only allow AOT to use the Android NDK when LLVM is enabled, as that is how things work today?

After we merge this, is it worth making the lookup of the NDK in xamarin-android-tools optional?

I'm not sure we want to do this quite yet, as I think that lookup will set $(_AndroidNdkDirectory) wihch is still used by BuildApk (required when $(_AndroidCheckedBuild) is true), and MakeBundleNativeCodeExternal.

jonathanpeppers · 2022-05-05T20:58:42Z

Right now I don't think you can use LLVM without having an NDK -- but I was thinking we could fix that? Like it should be possible to work?

If you didn't need the NDK, we could enable LLVM by default for Release builds to improve startup times.

pjcollins · 2022-05-05T21:32:24Z

LLVM doesn't need the NDK as far as I have seen, this PR will allow AOT+LLVM builds to work without the Android NDK (and not use the Android NDK by default).

pjcollins · 2022-05-10T15:56:19Z

The latest test failures appear to be ignorable. I spent some more time testing this today but am blocked on LLVM configurations with .NET 7 due to a known crash. We may want to consider holding this until we can further test LLVM with .NET 7.

Right now I don't think you can use LLVM without having an NDK -- but I was thinking we could fix that? Like it should be possible to work?

@jonathanpeppers do you happen to remember a scenario where LLVM relied on the NDK? When previously testing this against .NET 6 and classic LLVM was working for me without the NDK at least in some simple project template cases.

jonathanpeppers · 2022-05-10T16:06:58Z

@pjcollins in #6539 I remember some LLVM tests failed when I tried, but there are other changes in xamarin-android/main now. Could the LLVM-IR support @grendello added make this work now?

If you're testing, and LLVM is working without an NDK let's try it.

It appears that an Android NDK installation is no longer needed when using Aot with LLVM. Projects which enable Aot and LLVM will no longer attempt to use the NDK unless it is explicitly requested by setting `$(AndroidNdkDirectory)` to a valid NDK path in the project file.

pjcollins · 2022-09-07T21:21:38Z

/azp run

azure-pipelines · 2022-09-07T21:22:13Z

Azure Pipelines successfully started running 1 pipeline(s).

pjcollins · 2022-09-07T22:32:54Z

There are a couple of bugs to revisit in the future once we have the latest 7.0.100 RC builds from runtime, but this should be good to go if CI looks good.

grendello · 2022-09-08T08:50:01Z

src/Xamarin.Android.Build.Tasks/Tasks/GetAotArguments.cs

@@ -306,7 +307,9 @@ string GetLdFlags(NdkTools ndk, AndroidTargetArch arch, int level, string toolPr
 				// Without the flag, `lld` will modify AOT-generated code in a way that the Mono runtime doesn't support. Until
 				// the runtime issue is fixed, we need to pass this flag then.
 				//
-				ldFlags.Append ("--no-relax");
+				if (!UseAndroidNdk) {


I wonder if (at some point, not necessarily in this PR) we could detect the version of LLVM in the NDK and append --no-relax if that version is >= 14

* main: Bump to dotnet/installer@dd355bb 7.0.100-rc.2.22457.6 (dotnet#7360) [Xamarin.Android.Build.Tasks] Use binutils for Aot and LLVM (dotnet#6901)

TomSoPolaris · 2022-10-28T20:22:21Z

Hi, we're hoping this fixes #7352. Has this been released yet? I'm not good at knowing how issues make it into releases and get shipped. Would appreciate some insight.
We had to disable LLVM on our Android app store builds or else they'd insta-crash on launch.

pjcollins force-pushed the test-llvm-no-ndk branch 2 times, most recently from 69fc7e5 to dbe508e Compare April 7, 2022 17:01

pjcollins commented Apr 7, 2022

View reviewed changes

src/Xamarin.Android.Build.Tasks/Tasks/GetAotArguments.cs Show resolved Hide resolved

pjcollins mentioned this pull request Apr 7, 2022

[build] Fix AOT no-write-symbols test #6900

Closed

pjcollins changed the title ~~Try to use local binutils for LLVM~~ [Xamarin.Android.Build.Tasks] Use our binutils when $(EnableLLVM)=true Apr 7, 2022

pjcollins force-pushed the test-llvm-no-ndk branch from dbe508e to b8ae8e7 Compare April 8, 2022 21:09

pjcollins changed the title ~~[Xamarin.Android.Build.Tasks] Use our binutils when $(EnableLLVM)=true~~ [Xamarin.Android.Build.Tasks] Use our toolchain when $(EnableLLVM)=true Apr 12, 2022

pjcollins force-pushed the test-llvm-no-ndk branch 2 times, most recently from f03ab69 to a8e7272 Compare April 12, 2022 22:11

pjcollins force-pushed the test-llvm-no-ndk branch from a8e7272 to aa58775 Compare May 3, 2022 21:05

pjcollins changed the title ~~[Xamarin.Android.Build.Tasks] Use our toolchain when $(EnableLLVM)=true~~ [Xamarin.Android.Build.Tasks] Use binutils for Aot May 3, 2022

pjcollins force-pushed the test-llvm-no-ndk branch 5 times, most recently from 36c2652 to b4e56a3 Compare May 5, 2022 18:35

pjcollins added the do-not-merge PR should not be merged. label May 5, 2022

pjcollins marked this pull request as ready for review May 5, 2022 18:35

pjcollins requested review from jonathanpeppers and dellis1972 as code owners May 5, 2022 18:35

pjcollins requested review from jonpryor and grendello May 5, 2022 18:36

grendello approved these changes May 5, 2022

View reviewed changes

jonathanpeppers approved these changes May 5, 2022

View reviewed changes

pjcollins added do-not-merge PR should not be merged. and removed do-not-merge PR should not be merged. labels May 5, 2022

pjcollins removed the do-not-merge PR should not be merged. label May 10, 2022

pjcollins changed the title ~~[Xamarin.Android.Build.Tasks] Use binutils for Aot~~ [Xamarin.Android.Build.Tasks] Use binutils for Aot and LLVM May 10, 2022

pjcollins added this to the .NET 7 milestone Jul 6, 2022

pjcollins force-pushed the test-llvm-no-ndk branch 4 times, most recently from f5ac71f to 9770e8d Compare August 17, 2022 22:13

pjcollins force-pushed the test-llvm-no-ndk branch from 9770e8d to 538bf6b Compare August 25, 2022 19:34

jonpryor assigned pjcollins Aug 29, 2022

jpobst added enhancement Proposed change to current functionality. Area: App+Library Build Issues when building Library projects or Application projects. labels Sep 6, 2022

pjcollins force-pushed the test-llvm-no-ndk branch from 538bf6b to 97ffc02 Compare September 6, 2022 20:42

pjcollins force-pushed the test-llvm-no-ndk branch from 97ffc02 to 4f56be8 Compare September 7, 2022 16:56

pjcollins requested review from jonathanpeppers and grendello September 7, 2022 22:30

grendello approved these changes Sep 8, 2022

View reviewed changes

grendello mentioned this pull request Sep 8, 2022

[Xamarin.Android] Assertion tramp-arm64.c:52, condition '((ins >> 24) & 0x1f) == 0x10' not met #7352

Closed

jonathanpeppers merged commit 346a933 into dotnet:main Sep 8, 2022

pjcollins deleted the test-llvm-no-ndk branch September 8, 2022 21:29

jonathanpeppers mentioned this pull request Sep 9, 2022

Android AOT+LLVM InvalidOperation_EnumEnded dotnet/runtime#73304

Closed

FoggyFinder mentioned this pull request Nov 29, 2022

Crash on startup after updating to Xamarin.Android 13.1.0.1 #7588

Closed

github-actions bot locked and limited conversation to collaborators Jan 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Xamarin.Android.Build.Tasks] Use binutils for Aot and LLVM #6901

[Xamarin.Android.Build.Tasks] Use binutils for Aot and LLVM #6901

pjcollins commented Apr 6, 2022 •

edited

Loading

jonathanpeppers left a comment

jonathanpeppers commented May 5, 2022

pjcollins commented May 5, 2022 •

edited

Loading

jonathanpeppers commented May 5, 2022

pjcollins commented May 5, 2022 •

edited

Loading

pjcollins commented May 10, 2022

jonathanpeppers commented May 10, 2022

pjcollins commented Sep 7, 2022

azure-pipelines bot commented Sep 7, 2022

pjcollins commented Sep 7, 2022

grendello Sep 8, 2022

TomSoPolaris commented Oct 28, 2022

[Xamarin.Android.Build.Tasks] Use binutils for Aot and LLVM #6901

[Xamarin.Android.Build.Tasks] Use binutils for Aot and LLVM #6901

Conversation

pjcollins commented Apr 6, 2022 • edited Loading

jonathanpeppers left a comment

Choose a reason for hiding this comment

jonathanpeppers commented May 5, 2022

pjcollins commented May 5, 2022 • edited Loading

jonathanpeppers commented May 5, 2022

pjcollins commented May 5, 2022 • edited Loading

pjcollins commented May 10, 2022

jonathanpeppers commented May 10, 2022

pjcollins commented Sep 7, 2022

azure-pipelines bot commented Sep 7, 2022

pjcollins commented Sep 7, 2022

grendello Sep 8, 2022

Choose a reason for hiding this comment

TomSoPolaris commented Oct 28, 2022

pjcollins commented Apr 6, 2022 •

edited

Loading

pjcollins commented May 5, 2022 •

edited

Loading

pjcollins commented May 5, 2022 •

edited

Loading