Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Add MAUI integration job #8200

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Conversation

pjcollins
Copy link
Member

@pjcollins pjcollins commented Jul 19, 2023

Adds a new MAUI test stage and job that will run against PR builds
targeting xamarin-android/main.

The new job will build dotnet/maui against the Android packs produced by
the PR build. If that is successful, it will install the MAUI packs
into Androids dotnet preview sandbox, and create and build a template.

@pjcollins pjcollins force-pushed the maui-integration branch 9 times, most recently from 5b40528 to bf90784 Compare July 22, 2023 00:25
Adds a new MAUI test stage and job that will run against PR builds
targeting xamarin-android/main.

The new job will build dotnet/maui against the Android packs produced by
the PR build.  If that is successful, it will install the MAUI packs
into Androids dotnet preview sandbox, and create and build a template.
@pjcollins pjcollins marked this pull request as ready for review July 22, 2023 19:48
@pjcollins pjcollins requested a review from jonpryor as a code owner July 22, 2023 19:48
- template: yaml-templates/stage-msbuild-emulator-tests.yaml
parameters:
usesCleanImages: ${{ parameters.macTestAgentsUseCleanImages }}

- stage: maui_tests
displayName: MAUI Tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nice this doesn't actually take that long:

image

build-tools/create-packs/Directory.Build.targets Outdated Show resolved Hide resolved
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise 👍

retryCountOnTaskFailure: 3
inputs:
projects: $(Build.SourcesDirectory)/xamarin-android/Xamarin.Android.sln
arguments: -t:InstallMaui -p:MauiUseLocalPacks=true -p:MauiWorkloadToInstall=maui -c $(XA.Build.Configuration) --no-restore -v:n -bl:$(Build.StagingDirectory)/logs/install-maui.binlog
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-p:MauiWorkloadToInstall=maui would install the ios workload, for example. I guess that is fine?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this would be easier than trying to edit the target frameworks of the template project file, but we can revisit this if it becomes problematic at all in the future.

@pjcollins pjcollins merged commit 805872b into dotnet:main Jul 24, 2023
46 of 49 checks passed
@pjcollins pjcollins deleted the maui-integration branch July 24, 2023 23:56
grendello added a commit to grendello/xamarin-android that referenced this pull request Jul 25, 2023
* main:
  [ci] Add MAUI integration job (dotnet#8200)
grendello added a commit to grendello/xamarin-android that referenced this pull request Jul 27, 2023
* main:
  [ci] Remove .NET branches from classic release trigger (dotnet#8218)
  Bump to dotnet/installer@f8bab721ae 8.0.100-rc.1.23373.1 (dotnet#8202)
  [Mono.Android] Fix Context.RegisterReceiver() enumification (dotnet#7735)
  [ci] Add MAUI integration job (dotnet#8200)
  [vs-workload] Set EnableSideBySideManifests=true (dotnet#8179)
grendello added a commit to grendello/xamarin-android that referenced this pull request Sep 4, 2023
* main:
  Bump to dotnet/installer@f8bab721ae 8.0.100-rc.1.23373.1 (dotnet#8202)
  [Mono.Android] Fix Context.RegisterReceiver() enumification (dotnet#7735)
  [ci] Add MAUI integration job (dotnet#8200)
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants