Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-merge] Add removed-since info. #8897

Merged
merged 1 commit into from
Apr 26, 2024
Merged

[api-merge] Add removed-since info. #8897

merged 1 commit into from
Apr 26, 2024

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Apr 23, 2024

Our process of building Mono.Android.dll's api.xml using api-merge does not take into account that API could be removed from android.jar.

Track API removals by adding a removed-since="XX" attribute to API that no longer exists.

Note this information is not currently consumed anywhere, but having this data will allow us to determine if we want to make modifications to handle it in future PRs. Potentially [UnsupportedOSPlatformAttribute] is a good solution for this.

@jpobst jpobst marked this pull request as ready for review April 24, 2024 00:14
@jpobst jpobst requested a review from jonpryor as a code owner April 24, 2024 00:14
@jonpryor
Copy link
Member

I wonder if the //*/@remove-since attribute values should be the value passed directly to the [UnsupportedOSPlatform] constructor, e.g. android23.0 instead of 23.

This would mean that if/when generator gets support for emitting [UnsupportedOSPlatform], it could just emit the value as-is.

@jpobst
Copy link
Contributor Author

jpobst commented Apr 25, 2024

I wonder if the //*/@remove-since attribute values should be the value passed directly to the [UnsupportedOSPlatform] constructor, e.g. android23.0 instead of 23.

Perhaps if we were starting from scratch, but we already have deprecated-since and api-since that generator understands, so using the same semantics for removed-since is probably better for consistency.

@jonpryor jonpryor merged commit 944d306 into main Apr 26, 2024
48 checks passed
@jonpryor jonpryor deleted the removed-since branch April 26, 2024 18:37
grendello added a commit that referenced this pull request Apr 30, 2024
* main:
  Localized file check-in by OneLocBuild Task (#8910)
  LEGO: Merge pull request 8909
  [api-merge] Add `removed-since` info (#8897)
grendello added a commit that referenced this pull request May 7, 2024
* main:
  Update README (#8913)
  Bumps to xamarin/Java.Interop/main@4e893bf (#8924)
  Bump to dotnet/installer@fa261b952d 9.0.100-preview.5.24253.16 (#8921)
  [Mono.Android] Dispose of the `RunnableImplementor` on error (#8907)
  Bump NDK to r26d (#8868)
  Bump to dotnet/installer@d301a122c4 9.0.100-preview.5.24229.2 (#8912)
  Localized file check-in by OneLocBuild Task (#8910)
  LEGO: Merge pull request 8909
  [api-merge] Add `removed-since` info (#8897)
  Bump to xamarin/monodroid@9ca6d9f6 (#8895)
  [Xamarin.Android.Build.Tasks] fix detection of "Android libraries" (#8904)
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants