Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python scripts should support Python 3 #13433

Closed
1 of 5 tasks
dsplaisted opened this issue May 5, 2023 · 7 comments
Closed
1 of 5 tasks

Python scripts should support Python 3 #13433

dsplaisted opened this issue May 5, 2023 · 7 comments

Comments

@dsplaisted
Copy link
Member

  • This issue is blocking
  • This issue is causing unreasonable pain

There are python scripts in https://github.com/dotnet/arcade/tree/main/src/Microsoft.DotNet.Build.Tasks.Installers/build/deb-package-tool/scripts that aren't compatible with Python 3. Python 2 is out of support by now, and Debian 12 will remove support for it entirely, so we probably need to update these scripts to be able to run on Python 3.

If it's not possible to author them to run in both versions of Python, this may be complicated because it would have to be coordinated with switching all of the CI images (that use deb-package-tool at least) to install Python 3 instead of Python 2).

For reference, this came up when we migrated to Debian 11, and the python command is no longer available by default:

FYI @marcpopMSFT @mmitche

Release Note Category

  • Feature changes/additions
  • Bug fixes
  • Internal Infrastructure Improvements

Release Note Description

@missymessa
Copy link
Member

/cc @dougbu and @garath because they've been working on this situation.

@dougbu
Copy link
Member

dougbu commented May 6, 2023

/cc @dougbu and @garath because they've been working on this situation.

Not sure we're really "working on this situation." There have been Python issues that affected multiple Core-Eng repos but I believe ancient code that runs only on Python 2 hasn't come up recently — before this issue.

We're looking closest at #13186. That issue is problematic because SLES 12 supports only Python 3.4 and we need at least one newer package that is incompatible w/ that Python version.

@missymessa
Copy link
Member

@ericstj I think this is something that Runtime needs to handle?

@ericstj
Copy link
Member

ericstj commented Jun 15, 2023

I think the installer infrastructure is owned by @NikolaMilosavljevic, however it looks like @jkoritzinsky might have already helped out with this in dd4ebc5.

@jkoritzinsky
Copy link
Member

Yes, I handled this to get the DEB packaging legs to run on Ubuntu 22.04

@missymessa
Copy link
Member

Yes, I handled this to get the DEB packaging legs to run on Ubuntu 22.04

Great! Are we able to close out this issue, or is there more work that needs to be done?

@jkoritzinsky
Copy link
Member

Yes, I think we can close this. Any other work is tracked by #13186.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants