Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0.1xx] Install libLLDB 9 #16283

Merged
merged 7 commits into from
May 3, 2023

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Apr 28, 2023

  • Please add description for changes you are making.
  • If there is an issue related to this PR, please add the reference.

@marcpopMSFT
Copy link
Member

CC @dsplaisted

@mmitche mmitche enabled auto-merge (squash) April 28, 2023 18:06
Copy link
Member

@dsplaisted dsplaisted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch. 🎉 Hope this works!

@marcpopMSFT
Copy link
Member

So Matt's changes fixed the build but we have a couple of 1.1 tests that aren't supported on this platform. Is there a specific RID we can look out for here: https://github.com/dotnet/sdk/blob/main/src/Tests/Microsoft.NET.TestFramework/EnvironmentInfo.cs#L55 or is debian just a generic linux rid? If so, should we finally disable 1.1 tests in installer on the various linux platforms? We'll still have sdk repo coverage on unbuntu.

CC @dsplaisted

@marcpopMSFT
Copy link
Member

Dug into the test code and confirmed that it's reporting debian.11-x64 for the rid. Here's the fix in installer for this as nothing below 2.1 is supported on debian: dotnet/sdk#32127. So we either merge all servicing on red for two months or we could disable these two tests on linux for two months.

@marcpopMSFT
Copy link
Member

realized that we'd already disabled these two tests on linux in main so went ahead and cherry-picked that. We can undo that once my sdk PR is in if we like in two months.

@marcpopMSFT
Copy link
Member

@mmitche ok, it's now failing to find package_tool.sh. As far as I can tell, that used to be included on the image by default and I'm not sure what component brought that in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants