Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update OctoKit to 12.0.0 #14828

Merged
merged 1 commit into from
Jun 11, 2024
Merged

[main] Update OctoKit to 12.0.0 #14828

merged 1 commit into from
Jun 11, 2024

Conversation

lbussell
Copy link
Contributor

@lbussell
Copy link
Contributor Author

Migrating package... https://dev.azure.com/dnceng/internal/_build/results?buildId=2470208&view=results

@lbussell
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

dougbu
dougbu approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but please confirm Octokit is exercised enough in the validation build to ensure we won't hit regressions / breaking changes in production.

@lbussell
Copy link
Contributor Author

lbussell commented Jun 11, 2024 •
edited
Loading

Approving but please confirm Octokit is exercised enough in the validation build to ensure we won't hit regressions / breaking changes in production.

@dougbu, this update to OctoKit should only change comment IDs from ints to longs. Microsoft.DotNet.Git.IssueManager doesn't expose that ID so this is not a breaking change.

@lbussell lbussell merged commit c0a26be into dotnet:main Jun 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

@mthalman mthalman mthalman approved these changes

@missymessa missymessa Awaiting requested review from missymessa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lbussell @dougbu @mthalman