Revert NuGet.Versioning version to 4.4.0 #2189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmat
changed the title
tmat
force-pushed
the
RevertNuGetVersioning
branch
from
51826e3
to
89a2d03
Compare
|
You need to revert more than just this, NuGetVersion update is also causing problems in CoreFx. The reason these are failing on .NETCore is that MSBuild includes the NuGet assemblies in its deps file. This effectively creates an upper-limit for the versions of those DLLs that an msbuild task can reference. I took a look at the SDK version we use in CoreFx (2.2.103) and it has NuGet 4.9.2, so you could probably use that if it has the APIs you want. |
This was referenced Mar 21, 2019
Closed
This was referenced Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newer version is causing build failures on .NET Core: https://dev.azure.com/dnceng/public/_build/results?buildId=116977
Need to investigate why, reverting meanwhile.