Disable automatic SDK references for internal tools #5417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't we ever restore internal tools on Unix? |
|
Test build just for the sake of seeing it work here: https://dev.azure.com/dnceng/internal/_build/results?buildId=631946&view=results |
What do you mean? Yes this is actually failing on Unix because the ref pack is not present in those machines. |
|
The test build went pass the restore internal tools step in all CoreCLR Unix legs and the Libraries Unix legs that got to that point. |
ericstj
approved these changes
May 5, 2020
|
I accidently believed that the refpack was necessary to restore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest SDK adds an automatic reference to
Microsoft.NETFramework.ReferenceAssembliesif targeting full framework and the targeting pack can't be found in the machine:dotnet/sdk@714c051#diff-81720bb5fb8b13c6dff8490812b4c44a
We should disable these references for repos to be able to restore internal tools with the newest SDK since in internal tools restore we shouldn't need to add nuget.org feed as the restore sources.
cc: @ericstj @tmat @ViktorHofer