-
Notifications
You must be signed in to change notification settings - Fork 10k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix form actions for apps deployed behind reverse proxy (#51403)
# Fix form actions for apps deployed behind reverse proxy Makes forms work for apps deployed behind a reverse proxy. ## Description Apps deployed behind a reverse proxy (e.g., container apps) should not try to emit absolute URLs by default because the scheme/hostname/port may differ from what is reachable from the outside world. The fix is to emit root-relative URLs. Fixes #51380 ## Customer Impact Without this fix, apps deployed behind a reverse proxy (e.g., in ACA) would not support form posts. ## Regression? - [ ] Yes - [x] No No because this only affects SSR forms, which is a new feature in .NET 8. ## Risk - [ ] High - [ ] Medium - [x] Low Low because this is only a change to how we generate the URL for a form's `action` attribute. Previously we used an absolute URL, but now we use a root-relative one. There is no other runtime change. Everything else in this PR is extra tests and updating existing tests. ## Verification - [x] Manual (required) - [x] Automated ## Packaging changes reviewed? - [ ] Yes - [ ] No - [x] N/A
- Loading branch information
1 parent
949aa42
commit 02bdf70
Showing
3 changed files
with
97 additions
and
77 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.