Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blazor WebAssembly perf: InitializeNewAttributeFrame should use culture-insensitive ordinal string comparison #24465

Closed
SteveSandersonMS opened this issue Jul 31, 2020 · 0 comments
Closed

Blazor WebAssembly perf: InitializeNewAttributeFrame should use culture-insensitive ordinal string comparison #24465

SteveSandersonMS opened this issue Jul 31, 2020 · 0 comments
Assignees
@SteveSandersonMS
Labels
area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly

Comments

@SteveSandersonMS
Copy link
Member

This is part of #22432

RenderTreeDiffBuilder currently does a culture-sensitive match when checking if an attribute name starts with on. This was not intentional - there's no reason we shouldn't do this with a culture-invariant match. This trivial change gives a 2-3% gain on the PlainTable/ComplexTable benchmarks.
@SteveSandersonMS SteveSandersonMS added area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly labels Jul 31, 2020
@SteveSandersonMS SteveSandersonMS self-assigned this Jul 31, 2020
@mkArtakMSFT mkArtakMSFT mentioned this issue Jul 31, 2020
Closed
31 tasks
SteveSandersonMS added a commit that referenced this issue Jul 31, 2020
@SteveSandersonMS
Use ordinal comparison when detecting event handler attributes. Fixes #…
d65de78 
…24465
@SteveSandersonMS SteveSandersonMS mentioned this issue Jul 31, 2020
Merged
HaoK pushed a commit that referenced this issue Aug 7, 2020
@SteveSandersonMS @HaoK
Use ordinal comparison when detecting event handler attributes. Fixes #…
d7a3ecf 
…24465 (#24471)
@ghost ghost locked as resolved and limited conversation to collaborators Aug 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@SteveSandersonMS SteveSandersonMS

Labels
area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SteveSandersonMS