Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some blazor event tests failures seem to be related and will fail together #31195

Closed
HaoK opened this issue Mar 24, 2021 · 3 comments · Fixed by #37890
Closed

Some blazor event tests failures seem to be related and will fail together #31195

HaoK opened this issue Mar 24, 2021 · 3 comments · Fixed by #37890
Assignees
Labels
area-blazor Includes: Blazor, Razor Components Done This issue has been fixed test-failure

Comments

@HaoK
Copy link
Member

HaoK commented Mar 24, 2021

From #31156
so there's something about the interaction between this set of quarantined tests that when they run will cause a large set of tests to fail. When we last unquarantined most of these we saw similar failures start in the CI, I really think our current system of only running the quarantined tests and not the full set of tests is not a good mechanism to verify that the tests well behave once unquarantined, we should be running the full set of normal tests + quarantined tests to accurately determine things are fixed

It looks like a bunch of the event tests failed together and caused more test to fail too:

The tests being unquarantined in events that seem to cause issues:
ServerEventTest.EventDuringBatchRendering_CanTriggerDOMEvents
EventBubblingTest.BubblingStandardEvent_FiredOnElementWithoutHandler
EventTest.PreventDefault_DotNotApplyByDefault
EventTest.InputEvent_RespondsOnKeystrokes
EventTest.InputEvent_RespondsOnKeystrokes_EvenIfUpdatesAreLaggy
RoutingTest.PreventDefault_CanBlockNavigation_ForInternalNavigation_PreventDefaultTarget
RoutingTest.PreventDefault_CanBlockNavigation_ForExternalNavigation_PreventDefaultAncestor
(also caused [Non]BubblingCustomEvent to all fail too which aren't currently quarantined and other preventdefault tests)

It would be good to figure out why there's cross test interaction in these event tests, I'm not sure these are definitely the culprits but something in that set of tests will cause massive failures when they are all enabled.

@HaoK HaoK added test-failure area-blazor Includes: Blazor, Razor Components labels Mar 24, 2021
@HaoK HaoK changed the title Some event tests failures seem to be related Some blazor event tests failures seem to be related and will fail together Mar 24, 2021
@javiercn javiercn added this to the Next sprint planning milestone Mar 24, 2021
@ghost
Copy link

ghost commented Mar 24, 2021

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We will evaluate the request when we are planning the work for the next milestone. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@ghost
Copy link

ghost commented May 17, 2021

Thanks for contacting us.

We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@ghost
Copy link

ghost commented Jun 15, 2021

Thanks for contacting us.

We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@mkArtakMSFT mkArtakMSFT removed this from the 6.0.0 milestone Oct 19, 2021
@mkArtakMSFT mkArtakMSFT added this to the 6.0-docs-infra milestone Oct 19, 2021
@pranavkm pranavkm self-assigned this Oct 27, 2021
@ghost ghost added the Working label Oct 27, 2021
pranavkm added a commit to pranavkm/aspnetcore that referenced this issue Oct 27, 2021
Removing quarantine attribute from tests in the aspnetcore-components-e2e pipeline with 100% success rates
over the lifetime of the pipeline.

This is primarily a cleanup activity as these tests are not run as part of the regular test pipeline and
unquarantining does not change the outcome of the build.

Fixes dotnet#23015
Fixes dotnet#31195
Fixes dotnet#34886
Fixes dotnet#34395
Fixes dotnet#33297
Fixes dotnet#33528
Fixes dotnet#32907
Fixes dotnet#34867
Fixes dotnet#33530
Fixes dotnet#33715
Fixes dotnet#34183
Fixes dotnet#33454
@ghost ghost added the Done This issue has been fixed label Oct 28, 2021
pranavkm added a commit that referenced this issue Oct 28, 2021
Removing quarantine attribute from tests in the aspnetcore-components-e2e pipeline with 100% success rates
over the lifetime of the pipeline.

This is primarily a cleanup activity as these tests are not run as part of the regular test pipeline and
unquarantining does not change the outcome of the build.

Fixes #23015
Fixes #31195
Fixes #34886
Fixes #34395
Fixes #33297
Fixes #33528
Fixes #32907
Fixes #34867
Fixes #33530
Fixes #33715
Fixes #34183
Fixes #33454
@ghost ghost removed the Working label Oct 28, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-blazor Includes: Blazor, Razor Components Done This issue has been fixed test-failure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants