Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Date Pipe for Angular Client #39274

Closed
giuliohome opened this issue Sep 25, 2021 · 5 comments
Closed

Use Date Pipe for Angular Client #39274

giuliohome opened this issue Sep 25, 2021 · 5 comments
Labels
area-ui-rendering Includes: MVC Views/Pages, Razor Views/Pages enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-spa feature-templates
Milestone

Comments

@giuliohome
Copy link

You should be using a date pipe in fetch-data.component.html at line 18, the fix is shown below

    <tr *ngFor="let forecast of forecasts">
      <td>{{ forecast.date | date }}</td>

or complete with time part

    <tr *ngFor="let forecast of forecasts">
      <td>{{ forecast.date | date :'medium' }}</td>

It looks quite better - either just a date

image

or date and time -

image

than the original vanilla version in ISO format

image


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@serpent5
Copy link
Contributor

@Rick-Anderson Should this be transferred to the https://github.com/dotnet/spa-templates repo?

@Rick-Anderson Rick-Anderson transferred this issue from another repository Dec 17, 2021
@bekir-ozturk bekir-ozturk transferred this issue from dotnet/templating Jan 3, 2022
@mkArtakMSFT mkArtakMSFT added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-spa feature-templates labels Jan 3, 2022
@mkArtakMSFT mkArtakMSFT added this to the Backlog milestone Jan 3, 2022
@ghost
Copy link

ghost commented Jan 3, 2022

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@mkArtakMSFT mkArtakMSFT added the enhancement This issue represents an ask for new feature or an enhancement to an existing one label Jan 3, 2022
@mkArtakMSFT
Copy link
Member

Thanks for contacting us. @giuliohome feel free to send us a PR with the proposal.
We'll get someone to review it next week.

@giuliohome
Copy link
Author

giuliohome commented Jan 3, 2022

At the moment I'm experiencing an issue with https and angular proxy: since it seems locked/limited in angular and unrelated to this specific issue here, I ignore it (*) by omitting the first https url from applicationUrl in launchSettings.json and I proceed with the test of this PR.

(*) I will open a different issue for this maybe, just in case it will be needed... I read that you recently introduced this new proxy approach... I don't know why it doesn't work for me (or, well, I guess it doesn't accept the redirect to https without a valid certificate), so, again, I detour it for now, but I remain perplexed, not only about the https proxy, but also about the landing page, the fact that aspnet core redirects to a new ng serve process... Opening the starting app URL in another tab in the browser triggers another ng serve? That sounds wrong.

giuliohome added a commit to giuliohome/spa-templates that referenced this issue Jan 3, 2022
@adityamandaleeka adityamandaleeka added area-ui-rendering Includes: MVC Views/Pages, Razor Views/Pages and removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Aug 25, 2023
@mkArtakMSFT
Copy link
Member

mkArtakMSFT commented Oct 10, 2023

As you may have seen already, we have decided to remove the SPA project templates from the .NET 8 SDK. As a result, we will not be taking any new changes here for non-servicing related needs.

@mkArtakMSFT mkArtakMSFT closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-ui-rendering Includes: MVC Views/Pages, Razor Views/Pages enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-spa feature-templates
Projects
None yet
Development

No branches or pull requests

4 participants