Added MapMiddleware extensions in EndpointBuilderExtension. #14468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavinan
requested review from
analogrelay,
jkotalik and
Tratcher
as code owners
Tratcher
reviewed
Sep 27, 2019
| /// <param name="pattern">The route pattern.</param> | ||
| /// <param name="action">The action to apply to the <see cref="IApplicationBuilder"/>.</param> | ||
| /// <returns>A <see cref="IEndpointConventionBuilder"/> that can be used to further customize the endpoint.</returns> | ||
| public static IEndpointConventionBuilder MapMiddleware( |
There was a problem hiding this comment.
Middleware is not the best term here, it's mapping an entire pipeline/builder. How well would these work if they were just a overloads of Map? Would the arguments conflict too much?
There was a problem hiding this comment.
How about MapMiddlewareEndpoint? It will be similar to MapMiddlewareRoute.
|
I'm going to close this PR until we finish some discussion about design in an issue. We can always re-open this or accept a new PR once a design is finalized. |
amcasey
added
the
area-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Addresses #14514