Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize render tree building via RenderTreeFrameArrayBuilder #24484

Merged
merged 23 commits into from
Aug 3, 2020
Merged

Optimize render tree building via RenderTreeFrameArrayBuilder #24484

merged 23 commits into from
Aug 3, 2020

Commits on Aug 3, 2020

  1. Remove RenderTreeFrame's "With..." methods, making it mutable

    @SteveSandersonMS
    SteveSandersonMS committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    7562cca View commit details
    Browse the repository at this point in the history

  2. Begin declaring RenderTreeArrayBuilder

    @SteveSandersonMS
    SteveSandersonMS committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    1dd4176 View commit details
    Browse the repository at this point in the history

  3. Split Append into "attribute" and "nonattribute" cases so I can inlin… 

    …e it more easily in a moment
    @SteveSandersonMS
    SteveSandersonMS committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    a8fcebd View commit details
    Browse the repository at this point in the history

  4. Inline AppendAttribute

    @SteveSandersonMS
    SteveSandersonMS committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    130a22c View commit details
    Browse the repository at this point in the history

  5. Inline AppendNonAttribute

    @SteveSandersonMS
    SteveSandersonMS committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    8d905bb View commit details
    Browse the repository at this point in the history

  6. Begin implementing Append methods in RenderTreeArrayBuilder

    @SteveSandersonMS
    SteveSandersonMS committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    f1e4aea View commit details
    Browse the repository at this point in the history

  7. Define more Append methods in RenderTreeArrayBuilder

    @SteveSandersonMS
    SteveSandersonMS committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    d425c4d View commit details
    Browse the repository at this point in the history

  8. More Append methods

    @SteveSandersonMS
    SteveSandersonMS committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    afb7dfd View commit details
    Browse the repository at this point in the history

  9. Add todo note for later

    @SteveSandersonMS
    SteveSandersonMS committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    d3f81af View commit details
    Browse the repository at this point in the history

  10. Rename RenderTreeArrayBuilder->RenderTreeFrameArrayBuilder

    @SteveSandersonMS
    SteveSandersonMS committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    874cde6 View commit details
    Browse the repository at this point in the history

  11. Add note about correctness issue to check

    @SteveSandersonMS
    SteveSandersonMS committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    297119b View commit details
    Browse the repository at this point in the history

  12. Perform equivalent optimization with RenderTreeEditArrayBuilder

    @SteveSandersonMS
    SteveSandersonMS committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    a1b498d View commit details
    Browse the repository at this point in the history

  13. Revert RenderTreeEditArrayBuilder, because it makes too little differ… 

    …ence
    @SteveSandersonMS
    SteveSandersonMS committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    6845cb5 View commit details
    Browse the repository at this point in the history

  14. Inline GrowBuffer. Gains another 1%.

    @SteveSandersonMS
    SteveSandersonMS committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    c34d410 View commit details
    Browse the repository at this point in the history

  15. Add implementation notes

    @SteveSandersonMS
    SteveSandersonMS committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    2220e03 View commit details
    Browse the repository at this point in the history

  16. Switch to more risk-averse implementation. Seems to affect wallclock … 

    …timings by only 1% at the most.
    @SteveSandersonMS
    SteveSandersonMS committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    81c342f View commit details
    Browse the repository at this point in the history

  17. Avoid removing methods

    @SteveSandersonMS
    SteveSandersonMS committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    98a23ac View commit details
    Browse the repository at this point in the history

  18. Simplify - revert some unnecessary changes

    @SteveSandersonMS
    SteveSandersonMS committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    3859d49 View commit details
    Browse the repository at this point in the history

  19. Rename RenderTreeFrame fields for internal use

    @SteveSandersonMS
    SteveSandersonMS committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    fc7872f View commit details
    Browse the repository at this point in the history

  20. Avoid exposing RenderTreeFrame mutability publicly.

    @SteveSandersonMS
    SteveSandersonMS committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    cb57cc9 View commit details
    Browse the repository at this point in the history

  21. Cleanup

    @SteveSandersonMS
    SteveSandersonMS committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    0a7db66 View commit details
    Browse the repository at this point in the history

  22. Cleanup

    @SteveSandersonMS
    SteveSandersonMS committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    48f5c76 View commit details
    Browse the repository at this point in the history

  23. Cleanup

    @SteveSandersonMS
    SteveSandersonMS committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    ca77e54 View commit details
    Browse the repository at this point in the history