Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle latest 2.2 and 3.1 site extension packages #25778

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Bundle latest 2.2 and 3.1 site extension packages #25778

merged 1 commit into from
Sep 11, 2020

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Sep 10, 2020

  • part of dotnet/aspnetcore-internal#3676

@dougbu dougbu requested review from BrennanConroy and a team September 10, 2020 18:03
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 10, 2020
@dougbu dougbu added feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform tell-mode Indicates a PR which is being merged during tell-mode labels Sep 10, 2020
@dougbu
Copy link
Member Author

dougbu commented Sep 10, 2020

/fyi @Pilchie

dougbu
dougbu commented Sep 10, 2020
View reviewed changes
eng/Versions.props
@@ -241,8 +241,8 @@
<SystemIdentityModelTokensJwtPackageVersion>6.7.1</SystemIdentityModelTokensJwtPackageVersion>
<!-- Packages from 2.1, 2.2, and 3.1 branches used for site extension build. -->
<MicrosoftAspNetCoreAzureAppServicesSiteExtension21PackageVersion>2.1.1</MicrosoftAspNetCoreAzureAppServicesSiteExtension21PackageVersion>
<MicrosoftAspNetCoreAzureAppServicesSiteExtension22PackageVersion>2.2.0</MicrosoftAspNetCoreAzureAppServicesSiteExtension22PackageVersion>
<MicrosoftAspNetCoreAzureAppServicesSiteExtension31PackageVersion>3.1.7-servicing-20372-13</MicrosoftAspNetCoreAzureAppServicesSiteExtension31PackageVersion>
<MicrosoftAspNetCoreAzureAppServicesSiteExtension22PackageVersion>2.2.5</MicrosoftAspNetCoreAzureAppServicesSiteExtension22PackageVersion>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't hurt will it @BrennanConroy❔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but also no point :D

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify: Do you want this line backed out❔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't care either way 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then please approve😺

@dougbu
Copy link
Member Author

dougbu commented Sep 10, 2020

/azp run aspnetcore-quarantined-pr

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dougbu dougbu merged commit 5f04dfc into release/5.0-rc2 Sep 11, 2020
@dougbu dougbu deleted the dougbu/site.extension.5.0 branch September 11, 2020 06:08
@runfoapp runfoapp bot mentioned this pull request Sep 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@wtgodbe wtgodbe wtgodbe approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dougbu @BrennanConroy @wtgodbe